Home » Mailing list archives » linux-kernel » 2007 » June » 21

Re: [PATCH] drop obsolete sys_ioctl export

Previous thread: [BUG] Sky2 driver in 2.6.22-rc5-git1-cfs-v17 by Ian Kumlien on Thursday, June 21, 2007 - 1:51 pm. (1 message)

Next thread: ACPI Regression on Dell E1501 by Tim Gardner on Thursday, June 21, 2007 - 2:04 pm. (13 messages)
[view original message]
From: Christoph Hellwig
Subject: [PATCH] drop obsolete sys_ioctl export
Date: Thursday, June 21, 2007 - 2:15 pm

sys_ioctl was only exported for our first version of compat ioctl
handling.  Now that the whole compat ioctl handling mess is more or
less sorted out there are no more modular users left and we can kill it.

There's one exception and that's sparc64's solaris compat module, but
sparc64 has it's own export predating the generic one by years for that
which this patch leaves untouched.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/fs/ioctl.c
===================================================================
--- linux-2.6.orig/fs/ioctl.c	2007-06-21 22:09:38.000000000 +0200
+++ linux-2.6/fs/ioctl.c	2007-06-21 22:10:39.000000000 +0200
@@ -182,11 +182,3 @@ asmlinkage long sys_ioctl(unsigned int f
  out:
 	return error;
 }
-
-/*
- * Platforms implementing 32 bit compatibility ioctl handlers in
- * modules need this exported
- */
-#ifdef CONFIG_COMPAT
-EXPORT_SYMBOL(sys_ioctl);
-#endif
-


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] drop obsolete sys_ioctl export
Date: Thursday, June 21, 2007 - 2:17 pm

From: Christoph Hellwig <hch@lst.de>

Acked-by: David S. Miller <davem@davemloft.net>
-


[ message continues ]
Previous thread: [BUG] Sky2 driver in 2.6.22-rc5-git1-cfs-v17 by Ian Kumlien on Thursday, June 21, 2007 - 1:51 pm. (1 message)

Next thread: ACPI Regression on Dell E1501 by Tim Gardner on Thursday, June 21, 2007 - 2:04 pm. (13 messages)