Re: INITIO scsi driver fails to work properly

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: James Bottomley
Date: Thursday, January 10, 2008 - 10:16 pm

On Fri, 2008-01-04 at 02:18 +0200, Filippos Papadopoulos wrote:

This proves the BAR0 to be non zero, but I also take it from your report
that the

initio: I/O port range 0x0 is busy.

message is also gone?


I think there's still one remaining bug from the sg_list conversion,
namely that cblk->sglen is never set, but it is used to count the number
of elements in the sg array.  Could you try this patch (on top of
everything else) and see if the problem is finally fixed?

Thanks,

James

---
diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index 01bf018..d038459 100644
--- a/drivers/scsi/initio.c
+++ b/drivers/scsi/initio.c
@@ -2603,6 +2603,7 @@ static void initio_build_scb(struct initio_host * host, struct scsi_ctrl_blk * c
 	nseg = scsi_dma_map(cmnd);
 	BUG_ON(nseg < 0);
 	if (nseg) {
+		cblk->sglen = nseg;
 		dma_addr = dma_map_single(&host->pci_dev->dev, &cblk->sglist[0],
 					  sizeof(struct sg_entry) * TOTAL_SG_ENTRY,
 					  DMA_BIDIRECTIONAL);


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: INITIO scsi driver fails to work properly, Filippos Papadopoulos, (Wed Dec 19, 1:48 am)
Re: INITIO scsi driver fails to work properly, Boaz Harrosh, (Wed Dec 19, 3:08 am)
Re: INITIO scsi driver fails to work properly, Matthew Wilcox, (Wed Dec 19, 6:29 am)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Wed Dec 19, 9:50 am)
Re: INITIO scsi driver fails to work properly, Matthew Wilcox, (Wed Dec 19, 10:05 am)
Re: INITIO scsi driver fails to work properly, Natalie Protasevich, (Thu Dec 20, 2:32 am)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Thu Dec 20, 8:08 am)
Re: INITIO scsi driver fails to work properly, Chuck Ebbert, (Fri Dec 21, 12:30 pm)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Fri Dec 21, 2:03 pm)
Re: INITIO scsi driver fails to work properly, Chuck Ebbert, (Fri Dec 21, 3:43 pm)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Fri Dec 21, 3:49 pm)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Thu Jan 10, 10:16 pm)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Fri Jan 11, 8:44 am)
Re: INITIO scsi driver fails to work properly, Filippos Papadopoulos, (Fri Jan 11, 9:44 am)
Re: INITIO scsi driver fails to work properly, Alan Cox, (Fri Jan 11, 10:01 am)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Fri Jan 11, 10:01 am)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Fri Jan 11, 10:33 am)
Re: INITIO scsi driver fails to work properly, Chuck Ebbert, (Fri Jan 11, 10:52 am)
Re: INITIO scsi driver fails to work properly, Filippos Papadopoulos, (Sun Jan 13, 5:28 am)
Re: INITIO scsi driver fails to work properly, FUJITA Tomonori, (Tue Jan 15, 10:59 pm)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Wed Jan 16, 7:57 am)
Re: INITIO scsi driver fails to work properly, Alan Cox, (Mon Jan 21, 3:20 pm)
Re: INITIO scsi driver fails to work properly, Filippos Papadopoulos, (Tue Jan 22, 10:50 am)
Re: INITIO scsi driver fails to work properly, James Bottomley, (Fri Jan 25, 9:49 am)
Re: INITIO scsi driver fails to work properly, Filippos Papadopoulos, (Fri Jan 25, 2:04 pm)