Re: [RFC] Per-thread getrusage

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Pavel Emelyanov

Date: Tuesday, January 29, 2008 - 1:29 am

Eric W. Biederman wrote:
quoted text> Pavel Emelyanov <xemul@openvz.org> writes:
>>> ...
>>> +asmlinkage long sys_thread_getrusage(int tid, struct rusage __user *ru)
>>> +{
>>> +	struct task_struct *tsk;
>>> +	tsk = find_task_by_pid(tid);
>>> +	return getrusage(tsk, RUSAGE_THREAD, ru);
>>> +}
>> Well, the find_task_by_pid() is really wrong here.
> 
> And find_task_by_pid should probably just be removed.
> 
> No need to provide function with the gun firmly pointed at our feet....

We are working to uncock it. If you feel you know how to do it
faster, it would be just terrific to review your patches.

quoted text> Eric
> 

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC] Per-thread getrusage, Vinay Sridhar, (Thu Jan 17, 1:27 am)

Re: [RFC] Per-thread getrusage, Ulrich Drepper, (Thu Jan 17, 8:42 am)

Re: [RFC] Per-thread getrusage, Roland McGrath, (Fri Jan 18, 6:14 pm)

[PATCH] RUSAGE_THREAD, Roland McGrath, (Fri Jan 18, 6:14 pm)

Re: [PATCH] RUSAGE_THREAD, Ulrich Drepper, (Fri Jan 18, 11:21 pm)

Re: [PATCH] RUSAGE_THREAD, Christoph Hellwig, (Mon Jan 21, 2:55 am)

Re: [PATCH] RUSAGE_THREAD, Michael Kerrisk, (Sat Jan 26, 12:23 am)

Re: [RFC] Per-thread getrusage, Andrew Morton, (Sun Jan 27, 10:52 pm)

Re: [RFC] Per-thread getrusage, Pavel Emelyanov, (Mon Jan 28, 12:48 am)

Re: [RFC] Per-thread getrusage, Sripathi Kodi, (Mon Jan 28, 1:24 am)

Re: [RFC] Per-thread getrusage, Andrew Morton, (Mon Jan 28, 2:10 am)

Re: [RFC] Per-thread getrusage, Andrew Morton, (Mon Jan 28, 2:22 am)

Re: [RFC] Per-thread getrusage, Pavel Emelyanov, (Mon Jan 28, 2:38 am)

Re: [RFC] Per-thread getrusage, Andrew Morton, (Mon Jan 28, 2:45 am)

Re: [RFC] Per-thread getrusage, Pavel Emelyanov, (Mon Jan 28, 2:57 am)

Re: [RFC] Per-thread getrusage, Eric W. Biederman, (Mon Jan 28, 1:43 pm)

Re: [RFC] Per-thread getrusage, Andrew Morton, (Mon Jan 28, 2:57 pm