Re: [bug] Re: [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rusty Russell
Date: Thursday, October 23, 2008 - 4:01 pm

On Thursday 23 October 2008 23:55:29 Ingo Molnar wrote:
...

Just drop it.  It's a conversion, so it doesn't really belong in this "new 
API" stuff.  Nothing depends on it, and we need to be sure it's that which is 
causing the blowup.

Oh, and here's (one) problem:

		*nodemask = node_to_cpumask(cpu_to_node(i));

This is an old-style cpumask_t assigment, but nodemask wasn't allocated 
NR_CPUS bits if CONFIG_CPUMASK_OFFSTACK.  This is why assignment is banned 
(and will eventually fail compile), but that conversion hasn't been done on 
sched.c yet, so this patch is ahead of its time.

Thanks,
Rusty.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/1]: cpumask: fix compiler errors/warnings, Mike Travis, (Thu Oct 23, 1:20 pm)
Re: [bug] Re: [PATCH 00/35] cpumask: Replace cpumask_t wit ..., Rusty Russell, (Thu Oct 23, 4:01 pm)