Home » Mailing list archives » linux-kernel » 2008 » November » 17

[patch 28/46] m68k: Fix off-by-one in m68k_setup_user_interrupt()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg KH
Subject: [patch 28/46] m68k: Fix off-by-one in m68k_setup_user_interrupt()
Date: Monday, November 17, 2008 - 12:16 am

2.6.27-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Geert Uytterhoeven <geert@linux-m68k.org>

commit 27123cbc264de89ce6951b1b4c84c223eb0f1702 upstream.

commit 69961c375288bdab7604e0bb1c8d22999bb8a347 ("[PATCH] m68k/Atari:
Interrupt updates") added a BUG_ON() with an incorrect upper bound
comparison, which causes an early crash on VME boards, where IRQ_USER is
8, cnt is 192 and NR_IRQS is 200.

Reported-by: Stephen N Chivers <schivers@csc.com.au>
Tested-by: Kars de Jong <jongk@linux-m68k.org>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 arch/m68k/kernel/ints.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/m68k/kernel/ints.c
+++ b/arch/m68k/kernel/ints.c
@@ -133,7 +133,7 @@ void __init m68k_setup_user_interrupt(un
 {
 	int i;
 
-	BUG_ON(IRQ_USER + cnt >= NR_IRQS);
+	BUG_ON(IRQ_USER + cnt > NR_IRQS);
 	m68k_first_user_vec = vec;
 	for (i = 0; i < cnt; i++)
 		irq_controller[IRQ_USER + i] = &user_irq_controller;

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/46] 2.6.27.7-stable review, Greg KH, (Mon Nov 17, 12:13 am)
[patch 01/46] touch_mnt_namespace when the mount flags change, Greg KH, (Mon Nov 17, 12:14 am)
[patch 02/46] iwlagn: avoid sleep in softirq context, Greg KH, (Mon Nov 17, 12:14 am)
[patch 03/46] ath5k: fix suspend-related oops on rmmod, Greg KH, (Mon Nov 17, 12:14 am)
[patch 04/46] ath5k: Fix reset sequence for AR5212 in gene ..., Greg KH, (Mon Nov 17, 12:14 am)
[patch 05/46] bnx2x: Removing the PMF indication when unlo ..., Greg KH, (Mon Nov 17, 12:14 am)
[patch 06/46] bnx2x: PCI configuration bug on big-endian, Greg KH, (Mon Nov 17, 12:14 am)
[patch 07/46] bnx2x: Calling netif_carrier_off at the end ..., Greg KH, (Mon Nov 17, 12:14 am)
[patch 08/46] ARM: 5329/1: Feroceon: fix feroceon_l2_inv_range, Greg KH, (Mon Nov 17, 12:14 am)
[patch 09/46] Fix platform drivers that crash on suspend/r ..., Greg KH, (Mon Nov 17, 12:14 am)
[patch 10/46] hostap: pad the skb-&gt;cb usage in lieu of a p ..., Greg KH, (Mon Nov 17, 12:14 am)
[patch 11/46] ACPI: avoid empty file name in sysfs, Greg KH, (Mon Nov 17, 12:14 am)
[patch 12/46] ACPI: EC: make kernel messages more useful w ..., Greg KH, (Mon Nov 17, 12:14 am)
[patch 13/46] hugetlb: make unmap_ref_private multi-size-aware, Greg KH, (Mon Nov 17, 12:15 am)
[patch 14/46] rtl8187: Add Abocom USB ID, Greg KH, (Mon Nov 17, 12:15 am)
[patch 15/46] rtl8187 : support for Sitecom WL-168 0001 v4, Greg KH, (Mon Nov 17, 12:15 am)
[patch 16/46] kbuild: Fixup deb-pkg target to generate sep ..., Greg KH, (Mon Nov 17, 12:15 am)
[patch 17/46] block: fix nr_phys_segments miscalculation bug, Greg KH, (Mon Nov 17, 12:15 am)
[patch 18/46] powerpc/mpic: Fix regression caused by chang ..., Greg KH, (Mon Nov 17, 12:15 am)
[patch 19/46] Input: ALPS - add signature for DualPoint fo ..., Greg KH, (Mon Nov 17, 12:15 am)
[patch 20/46] memory hotplug: fix page_zone() calculation ..., Greg KH, (Mon Nov 17, 12:15 am)
[patch 21/46] r8169: select MII in Kconfig, Greg KH, (Mon Nov 17, 12:15 am)
[patch 22/46] sony-laptop: ignore missing _DIS method on p ..., Greg KH, (Mon Nov 17, 12:15 am)
[patch 23/46] net: fix /proc/net/snmp as memory corruptor, Greg KH, (Mon Nov 17, 12:15 am)
[patch 24/46] Fix broken ownership of /proc/sys/ files, Greg KH, (Mon Nov 17, 12:15 am)
[patch 25/46] V4L/DVB (9624): CVE-2008-5033: fix OOPS on t ..., Greg KH, (Mon Nov 17, 12:15 am)
[patch 26/46] S390: cpu topology: fix locking, Greg KH, (Mon Nov 17, 12:15 am)
[patch 27/46] ACPI : Load device driver according to the s ..., Greg KH, (Mon Nov 17, 12:15 am)
[patch 28/46] m68k: Fix off-by-one in m68k_setup_user_inte ..., Greg KH, (Mon Nov 17, 12:16 am)
[patch 29/46] SCSI: qla2xxx: Return a FAILED status when a ..., Greg KH, (Mon Nov 17, 12:16 am)
[patch 30/46] SCSI: qla2xxx: Do not honour max_vports from ..., Greg KH, (Mon Nov 17, 12:16 am)
[patch 31/46] SCSI: qla2xxx: Correct Atmel flash-part hand ..., Greg KH, (Mon Nov 17, 12:16 am)
[patch 32/46] SCSI: dpt_i2o: fix transferred data length f ..., Greg KH, (Mon Nov 17, 12:16 am)
[patch 33/46] dm raid1: flush workqueue before destruction, Greg KH, (Mon Nov 17, 12:16 am)
[patch 34/46] USB: remove optional bus bindings in isp1760 ..., Greg KH, (Mon Nov 17, 12:16 am)
[patch 35/46] USB: gadget: cdc-acm deadlock fix, Greg KH, (Mon Nov 17, 12:16 am)
[patch 36/46] USB: unusual_devs entry for Argosy USB mass- ..., Greg KH, (Mon Nov 17, 12:16 am)
[patch 37/46] USB: Fix PS3 USB shutdown problems, Greg KH, (Mon Nov 17, 12:16 am)
[patch 38/46] USB: cdc-acm.c: fix recursive lock in acm_st ..., Greg KH, (Mon Nov 17, 12:16 am)
[patch 39/46] USB: EHCI: fix divide-by-zero bug, Greg KH, (Mon Nov 17, 12:16 am)
[patch 40/46] USB: EHCI: fix handling of dead controllers, Greg KH, (Mon Nov 17, 12:16 am)
[patch 41/46] USB: dont register endpoints for interfaces ..., Greg KH, (Mon Nov 17, 12:17 am)
[patch 42/46] ACPI: EC: revert msleep patch, Greg KH, (Mon Nov 17, 12:17 am)
[patch 43/46] ACPI: EC: wait for last write gpe, Greg KH, (Mon Nov 17, 12:17 am)
[patch 44/46] ACPI: EC: restart failed command, Greg KH, (Mon Nov 17, 12:17 am)
[patch 45/46] ACPI: EC: lower interrupt storm treshold, Greg KH, (Mon Nov 17, 12:17 am)
[patch 46/46] ACPI: EC: Dont do transaction from GPE handl ..., Greg KH, (Mon Nov 17, 12:17 am)
Re: [patch 25/46] V4L/DVB (9624): CVE-2008-5033: fix OOPS ..., Mauro Carvalho Chehab, (Mon Nov 17, 6:31 am)
Re: [patch 24/46] Fix broken ownership of /proc/sys/ files, Theodore Tso, (Mon Nov 17, 1:09 pm)
Re: [stable] [patch 24/46] Fix broken ownership of /proc/s ..., Greg KH, (Mon Nov 17, 2:35 pm)
Re: [stable] [patch 24/46] Fix broken ownership of /proc/s ..., Rafael J. Wysocki, (Mon Nov 17, 3:25 pm)
Re: [stable] [patch 24/46] Fix broken ownership of /proc/s ..., Peter Palfrader, (Mon Nov 17, 4:45 pm)