Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.) | KernelTrap

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Linus Torvalds

Subject: Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off aftersuspend-to-disk. Screen becomes green.)

Date: Friday, February 22, 2008 - 7:07 pm

On Sat, 23 Feb 2008, Rafael J. Wysocki wrote:
quoted text> 
> In the revised patch below I redefined the PM_EVENT_* things as flags so
> that I can "or" them and defined PM_EVENT_SLEEP in analogy with
> CONFIG_PM_SLEEP.

Ok, looks fine by me.

quoted text> > Didn't you miss the apci_pci_choose_state() thing that also needs this 
> > extension?
> 
> No, I didn't.  That one operates on the ACPI D* states.

Ok. I consider that just about the worst interface ever, but whatever...

quoted text> OK, please have a look at the modified patch below.

All right, I'm fine with it. Now we just need to confirm that it works for 
people..

		Linus
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Pavel Machek, (Sun Feb 17, 11:31 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 10:17 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 10:19 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Linus Torvalds, (Wed Feb 20, 10:28 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 10:37 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 10:50 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Linus Torvalds, (Wed Feb 20, 10:52 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 10:54 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 11:02 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 11:29 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Linus Torvalds, (Wed Feb 20, 11:37 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Mark Lord, (Wed Feb 20, 11:47 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 11:49 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 11:53 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 11:57 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 12:10 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 12:18 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Matthew Garrett, (Wed Feb 20, 12:25 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 1:09 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Rafael J. Wysocki, (Wed Feb 20, 1:14 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Linus Torvalds, (Wed Feb 20, 1:29 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Pablo Sanchez, (Wed Feb 20, 1:33 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 1:41 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Wed Feb 20, 1:45 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Linus Torvalds, (Wed Feb 20, 2:13 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Alexey Starikovskiy, (Wed Feb 20, 2:26 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 2:37 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 2:44 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Linus Torvalds, (Wed Feb 20, 3:22 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 3:32 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Rafael J. Wysocki, (Wed Feb 20, 3:36 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Nigel Cunningham, (Wed Feb 20, 3:45 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 4:03 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Linus Torvalds, (Wed Feb 20, 4:13 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 4:34 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Rafael J. Wysocki, (Wed Feb 20, 4:35 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Rafael J. Wysocki, (Wed Feb 20, 4:49 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Linus Torvalds, (Wed Feb 20, 5:00 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Rafael J. Wysocki, (Wed Feb 20, 5:13 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Matthew Garrett, (Wed Feb 20, 5:13 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 5:17 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Linus Torvalds, (Wed Feb 20, 5:25 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 5:35 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 5:39 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Nigel Cunningham, (Wed Feb 20, 5:40 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Greg KH, (Wed Feb 20, 5:46 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Rafael J. Wysocki, (Wed Feb 20, 5:59 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Wed Feb 20, 6:07 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Matthew Garrett, (Wed Feb 20, 6:10 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Nigel Cunningham, (Wed Feb 20, 6:17 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 6:19 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jesse Barnes, (Wed Feb 20, 6:21 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Nigel Cunningham, (Wed Feb 20, 6:25 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 6:49 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Jeff Chua, (Wed Feb 20, 7:00 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Greg KH, (Wed Feb 20, 9:43 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Nigel Cunningham, (Wed Feb 20, 11:05 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Greg KH, (Wed Feb 20, 11:37 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., david, (Thu Feb 21, 1:30 am)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Thu Feb 21, 9:27 am)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jesse Barnes, (Thu Feb 21, 11:34 am)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Romano Giannetti, (Thu Feb 21, 12:43 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Thu Feb 21, 1:30 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jesse Barnes, (Thu Feb 21, 2:02 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Thu Feb 21, 3:11 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jesse Barnes, (Thu Feb 21, 4:45 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jeff Chua, (Thu Feb 21, 5:20 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jesse Barnes, (Thu Feb 21, 5:23 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Thu Feb 21, 5:28 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Thu Feb 21, 5:31 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jeff Chua, (Thu Feb 21, 5:42 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jeff Chua, (Thu Feb 21, 5:42 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jesse Barnes, (Thu Feb 21, 5:46 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Linus Torvalds, (Thu Feb 21, 5:46 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jeff Chua, (Thu Feb 21, 5:48 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jeff Chua, (Thu Feb 21, 5:52 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Thu Feb 21, 5:54 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jeff Chua, (Thu Feb 21, 6:01 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jesse Barnes, (Thu Feb 21, 6:02 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Thu Feb 21, 6:06 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jesse Barnes, (Thu Feb 21, 6:13 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jeff Chua, (Thu Feb 21, 6:27 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Linus Torvalds, (Thu Feb 21, 6:28 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jesse Barnes, (Thu Feb 21, 6:35 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Jesse Barnes, (Thu Feb 21, 6:44 pm)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Matthew Garrett, (Fri Feb 22, 3:37 am)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Ingo Molnar, (Fri Feb 22, 6:06 am)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Rafael J. Wysocki, (Fri Feb 22, 9:10 am)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Linus Torvalds, (Fri Feb 22, 9:50 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Mark Lord, (Fri Feb 22, 9:54 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Mark Lord, (Fri Feb 22, 9:56 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Rafael J. Wysocki, (Fri Feb 22, 10:02 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Mark Lord, (Fri Feb 22, 10:32 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Rafael J. Wysocki, (Fri Feb 22, 10:44 am)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Matthew Garrett, (Fri Feb 22, 11:01 am)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., david, (Fri Feb 22, 12:23 pm)

Re: 2.6.25-rc2 System no longer powers off after suspend-t ..., Rafael J. Wysocki, (Fri Feb 22, 4:16 pm)

i915 hibernation patch (was: Re: [Suspend-devel] 2.6.25-rc ..., Rafael J. Wysocki, (Fri Feb 22, 4:31 pm)

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.2 ..., Linus Torvalds, (Fri Feb 22, 6:00 pm)

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.2 ..., Rafael J. Wysocki, (Fri Feb 22, 6:55 pm)

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.2 ..., Linus Torvalds, (Fri Feb 22, 7:07 pm)

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.2 ..., Jeff Chua, (Fri Feb 22, 9:36 pm)

Re: i915 hibernation patch (was: Re: [Suspend-devel] 2.6.2 ..., Pavel Machek, (Sat Feb 23, 4:17 am)

Re: [Suspend-devel] 2.6.25-rc2 System no longer powers off ..., Ingo Molnar, (Sat Feb 23, 4:17 am)

[PATCH] PM: Introduce PM_EVENT_HIBERNATE (was: Re: i915 hi ..., Rafael J. Wysocki, (Sat Feb 23, 11:13 am)

Re: [PATCH] PM: Introduce PM_EVENT_HIBERNATE (was: Re: i91 ..., Linus Torvalds, (Sat Feb 23, 11:43 am)

Re: [PATCH] PM: Introduce PM_EVENT_HIBERNATE (was: Re: i91 ..., Mirco Tischler, (Sat Feb 23, 9:16 pm)

Re: [PATCH] PM: Introduce PM_EVENT_HIBERNATE (was: Re: i91 ..., Pavel Machek, (Sun Feb 24, 1:29 am)

Re: [PATCH] PM: Introduce PM_EVENT_HIBERNATE (was: Re: i91 ..., Rafael J. Wysocki, (Sun Feb 24, 4:11 am)

Re: [PATCH] PM: Introduce PM_EVENT_HIBERNATE (was: Re: i91 ..., Rafael J. Wysocki, (Sun Feb 24, 4:25 am)

Re: [PATCH] PM: Introduce PM_EVENT_HIBERNATE (was: Re: i91 ..., Jeff Chua, (Sun Feb 24, 8:21 am)