Home » Mailing list archives » linux-kernel » 2008 » February » 23

[PATCH] x86: fix build on non-C locales.

Previous thread: [PATCH try #1] Kconfig: cleanup block/Kconfig help descriptions by Nick Andrew on Saturday, February 23, 2008 - 4:05 pm. (3 messages)

Next thread: [PATCH 03/10] CGroup API files: Use read_u64 in memory controller by menage on Saturday, February 23, 2008 - 3:47 pm. (1 message)
[view original message]
From: Priit Laes
Subject: [PATCH] x86: fix build on non-C locales.
Date: Saturday, February 23, 2008 - 4:05 pm

[ message continues ]
[view original message]
From: Ingo Molnar
Subject: Re: [PATCH] x86: fix build on non-C locales.
Date: Sunday, February 24, 2008 - 1:07 am

thanks, applied.

	Ingo
--


[ message continues ]
[view original message]
From: Sam Ravnborg
Subject: Re: [PATCH] x86: fix build on non-C locales.
Date: Sunday, February 24, 2008 - 2:03 am

Hi Prit.

Could we just use [[:alnum:]] and drop the setting of LC_ALL?

	Sam
--


[ message continues ]
[view original message]
From: Priit Laes
Subject: Re: [PATCH] x86: fix build on non-C locales.
Date: Sunday, February 24, 2008 - 9:36 am

Yes, it works. Reverted the previous patch and did this:

diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
index f385a4b..b8bd0c4 100644
--- a/arch/x86/vdso/Makefile
+++ b/arch/x86/vdso/Makefile
@@ -48,7 +48,7 @@ obj-$(VDSO64-y)                       += vdso-syms.lds
 # Match symbols in the DSO that look like VDSO*; produce a file of
constants.
 #
 sed-vdsosym := -e 's/^00*/0/' \
-       -e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p'
+       -e 's/^\([[:xdigit:]]*\) . \(VDSO[[:alnum:]_]*\)$$/\2 = 0x\1;/p'
 quiet_cmd_vdsosym = VDSOSYM $@
       cmd_vdsosym = $(NM) $< | sed -n $(sed-vdsosym) | LC_ALL=C sort >
$@

--


[ message continues ]
[view original message]
From: Ingo Molnar
Subject: Re: [PATCH] x86: fix build on non-C locales.
Date: Sunday, February 24, 2008 - 9:49 am

thanks, i picked up this one instead of the first version.

	Ingo
--


[ message continues ]
Previous thread: [PATCH try #1] Kconfig: cleanup block/Kconfig help descriptions by Nick Andrew on Saturday, February 23, 2008 - 4:05 pm. (3 messages)

Next thread: [PATCH 03/10] CGroup API files: Use read_u64 in memory controller by menage on Saturday, February 23, 2008 - 3:47 pm. (1 message)