Ingo Molnar wrote:
quoted text
> * Sam Ravnborg <sam@ravnborg.org> wrote:
> 
>> Hi Cyrill.
>> On Mon, Feb 04, 2008 at 08:10:37PM +0300, Cyrill Gorcunov wrote:
>>> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>> The patch looks simple but please explain why you do what you do. It 
>> took me some digging before I could convince mysleft this was indeed a 
>> correct change. And I am pretty sure you did the same investigation 
>> yourself.
>>
>> A comment like:
>>
>> arch/x866/kernel/inittask.c require all variables allocated in
>> the section .data.init_task to be aligned with THREAD_SIZE.
>>
>> would have made me happy.
> 
> Btw., given that on x86 we've moved away from the %esp based task stack 
> trick and use an %fs based Percpu-Data-Area (PDA) to access the current 
> task pointer, this alignment might not be necessary anymore. It's a 
> historic relic of the mask-%esp trick.
> 

Was that *ever* used on x86-64?  I thought x86-64 always used %gs for this.

	-hpa
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/