Re: [PATCH] i810fb: Fix console switch regression

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Stefan Bauer
Date: Monday, March 17, 2008 - 8:41 am

I'm sorry for the spaces in the second patch, here's a clean one with tabs.

---
From: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>

Since 4c7ffe0b9f7f40bd818fe3af51342f64c483908e ("fbdev: prevent drivers that 
have hardware cursors from calling software cursor code") every call of 
i810fb_cursor fails with -ENXIO because of a incorrect "!".

This hasn't striked until eaa0ff15c30dc9799eb4d12660edb73aeb6d32c5 ("fix ! 
versus & precedence in various places") surrounded the expression with 
braces, so that the intended behavior was inverted. That caused 'pixel 
waste' - the same line of multi-colored pixels repeated over the whole 
screen - during console switch.

This switches back to the original pre-4c7ffe0 behavior.

Signed-off-by: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Antonino Daplas <adaplas@pol.net>

--- linux-2.6/drivers/video/i810/i810_main.c.orig
+++ linux-2.6/drivers/video/i810/i810_main.c
@@ -1476,7 +1476,7 @@ static int i810fb_cursor(struct fb_info 
 	struct i810fb_par *par = info->par;
 	u8 __iomem *mmio = par->mmio_start_virtual;
 
-	if (!(par->dev_flags & LOCKUP))
+	if (par->dev_flags & LOCKUP)
 		return -ENXIO;
 
 	if (cursor->image.width > 64 || cursor->image.height > 64)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] i810fb: Fix console switch regression, Stefan Bauer, (Sun Mar 16, 11:42 am)
Re: [Linux-fbdev-devel] [PATCH] i810fb: Fix console switch ..., Geert Uytterhoeven, (Sun Mar 16, 12:48 pm)
Re: [PATCH] i810fb: Fix console switch regression, Henrique de Moraes H ..., (Sun Mar 16, 12:57 pm)
Re: [PATCH] i810fb: Fix console switch regression, Henrique de Moraes H ..., (Sun Mar 16, 1:02 pm)
Re: [PATCH] i810fb: Fix console switch regression, Stefan Bauer, (Mon Mar 17, 1:20 am)
Re: [PATCH] i810fb: Fix console switch regression, Stefan Bauer, (Mon Mar 17, 8:41 am)
Re: [PATCH] i810fb: Fix console switch regression, Andrew Morton, (Mon Mar 17, 8:48 pm)
Re: [PATCH] i810fb: Fix console switch regression, Stefan Bauer, (Tue Mar 18, 12:09 am)