Re: 2.6.25-rc5-mm1 sparc64 boot problems due to generic pci_enable_resources()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Friday, March 28, 2008 - 4:10 pm

From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Date: Fri, 28 Mar 2008 23:52:10 +0100


Yes, that generic code won't work because of the NULL
r->parent check.

Alpha, ARM, V32, FRV, IA64, MIPS, MN10300, PARISC, PPC,
SH, V850, X86, and Xtensa are all likely to run into
problems because of this change.

The only platform that did the check as a test of r->parent
being NULL is Powerpc.

The rest either didn't check (like sparc64), or tested it by going:

	if (!r->start && r->end)

So the amount of potential breakage from this change is enormous.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc5-mm1, Andrew Morton, (Tue Mar 11, 1:14 am)
[Build Faliure] 2.6.25-rc5-mm1 build fails , Kamalesh Babulal, (Tue Mar 11, 3:16 am)
Re: [Build Faliure] 2.6.25-rc5-mm1 build fails, Edward Shishkin, (Tue Mar 11, 3:56 am)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Randy Dunlap, (Tue Mar 11, 10:09 am)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Jeremy Fitzhardinge, (Tue Mar 11, 11:18 am)
Re: [Build Failure] 2.6.25-rc5-mm1 Build fails with allmod ..., Bartlomiej Zolnierki ..., (Tue Mar 11, 12:35 pm)
Re: [Build Failure] 2.6.25-rc5-mm1 Build fails with allmod ..., Bartlomiej Zolnierki ..., (Tue Mar 11, 12:36 pm)
Re: 2.6.25-rc5-mm1, serge, (Tue Mar 11, 1:23 pm)
Re: 2.6.25-rc5-mm1, Andrew Morton, (Tue Mar 11, 1:39 pm)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Ravikiran G Thirumalai, (Tue Mar 11, 5:10 pm)
Re: 2.6.25-rc5-mm1, Dave Young, (Tue Mar 11, 6:14 pm)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Randy Dunlap, (Tue Mar 11, 6:42 pm)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Jeremy Fitzhardinge, (Tue Mar 11, 6:51 pm)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Ingo Molnar, (Wed Mar 12, 12:14 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem ?, Badari Pulavarty, (Wed Mar 12, 11:10 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem ?, Andrew Morton, (Wed Mar 12, 11:15 am)
Re: 2.6.25-rc5-mm1, Torsten Kaiser, (Wed Mar 12, 12:33 pm)
Re: 2.6.25-rc5-mm1, Andrew Morton, (Wed Mar 12, 12:44 pm)
Re: 2.6.25-rc5-mm1, Torsten Kaiser, (Wed Mar 12, 1:01 pm)
Re: [BUG] 2.6.25-rc5-mm1 kernel panic with &quot;Exception: 501 ..., Benjamin Herrenschmidt, (Wed Mar 12, 1:40 pm)
[2.6.25-rc5-mm1] BUG: spinlock bad magic early during boot, Tilman Schmidt, (Wed Mar 12, 4:54 pm)
[2.6.25-rc5-mm1] WARNING: at drivers/base/sys.c:173, Tilman Schmidt, (Wed Mar 12, 5:15 pm)
Re: 2.6.25-rc5-mm1 shutdown crash, Helge Hafting, (Thu Mar 13, 7:03 am)
Re: 2.6.25-rc5-mm1 shutdown crash, Andrew Morton, (Thu Mar 13, 9:12 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch, Badari Pulavarty, (Thu Mar 13, 10:09 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch, Badari Pulavarty, (Thu Mar 13, 10:40 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch, Guillaume Chazarain, (Thu Mar 13, 10:55 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch, Badari Pulavarty, (Thu Mar 13, 11:20 am)
Re: 2.6.25-rc5-mm1, Torsten Kaiser, (Thu Mar 13, 3:05 pm)
Re: 2.6.25-rc5-mm1: &quot;consolechars&quot; hangs on boot, Laurent Riffard, (Thu Mar 13, 3:07 pm)
Re: 2.6.25-rc5-mm1, Andrew Morton, (Thu Mar 13, 3:35 pm)
Re: 2.6.25-rc5-mm1, Badari Pulavarty, (Thu Mar 13, 4:10 pm)
Re: [2.6.25-rc5-mm1] WARNING: at drivers/base/sys.c:173, Tilman Schmidt, (Thu Mar 13, 5:01 pm)
Re: 2.6.25-rc5-mm1: &quot;consolechars&quot; hangs on boot, Oleg Nesterov, (Thu Mar 13, 10:26 pm)
Re: [2.6.25-rc5-mm1] WARNING: at drivers/base/sys.c:173, Tilman Schmidt, (Fri Mar 14, 2:58 am)
Re: 2.6.25-rc5-mm1: &quot;consolechars&quot; hangs on boot, Laurent Riffard, (Fri Mar 14, 2:06 pm)
Re: [2.6.25-rc5-mm1] WARNING: at drivers/base/sys.c:173, Tilman Schmidt, (Sat Mar 15, 5:16 am)
Re: 2.6.25-rc5-mm1 build failure of pcsp.c, Mariusz Kozlowski, (Sun Mar 16, 2:38 pm)
Re: [2.6.25-rc5-mm1] regression: cannot run Postfix sendma ..., Rafael J. Wysocki, (Thu Mar 20, 3:21 am)
Re: [2.6.25-rc5-mm1] regression: cannot run Postfix sendma ..., Rafael J. Wysocki, (Thu Mar 20, 7:38 am)
Re: 2.6.25-rc5-mm1, Ingo Molnar, (Fri Mar 21, 5:12 am)
Re: 2.6.25-rc5-mm1 shutdown crash, Helge Hafting, (Tue Mar 25, 5:23 am)
Re: 2.6.25-rc5-mm1 sparc64 boot problems due to generic pc ..., Mariusz Kozlowski, (Fri Mar 28, 3:52 pm)
Re: 2.6.25-rc5-mm1 sparc64 boot problems due to generic pc ..., David Miller, (Fri Mar 28, 4:10 pm)
Re: 2.6.25-rc5-mm1 sparc64 boot problems due to generic pc ..., Benjamin Herrenschmidt, (Fri Mar 28, 5:44 pm)