Home » Mailing list archives » linux-kernel » 2008 » March » 6

Re: [PATCH] x86_64: show apicid for cpu in proc

Previous thread: [PATCH] x86_64: fix amd_detect_cmp by Yinghai Lu on Thursday, March 6, 2008 - 2:11 am. (1 message)

Next thread: [PATCH] x86_64: double check the multi root bus with fam10h mmconf by Yinghai Lu on Thursday, March 6, 2008 - 2:15 am. (1 message)
[view original message]
From: Yinghai Lu
Subject: [PATCH] x86_64: show apicid for cpu in proc
Date: Thursday, March 6, 2008 - 2:13 am

[ message continues ]
[view original message]
From: Ingo Molnar
Subject: Re: [PATCH] x86_64: show apicid for cpu in proc
Date: Thursday, March 6, 2008 - 3:21 am

thanks, applied.

Note that the number of tabs were off and we generally print these IDs 
in %d, so i committed:

  seq_printf(m, "apicid\t\t: %d\n", c->apicid);

	Ingo
--


[ message continues ]
[view original message]
From: Andi Kleen
Subject: Re: [PATCH] x86_64: show apicid for cpu in proc
Date: Thursday, March 6, 2008 - 4:41 am

Seems a little redundant with the boot log, but ok.

But it's unclear to the user which apic ID is meant by that. There are
two different ones. The one in the LAPIC mapping and the one reported by
CPUID. They are not necessarily the same. I think you should clarify that
by renaming the field or perhaps report both.

-Andi
--


[ message continues ]
[view original message]
From: Yinghai Lu
Subject: Re: [PATCH] x86_64: show apicid for cpu in proc
Date: Thursday, March 6, 2008 - 12:23 pm

report the apicid and initial apicid at the same time?

but in current code, we didn't use the initial apicid...., actually
initial apic id is more better to get the responding to node/core.

will look at it.

YH
--


[ message continues ]
Previous thread: [PATCH] x86_64: fix amd_detect_cmp by Yinghai Lu on Thursday, March 6, 2008 - 2:11 am. (1 message)

Next thread: [PATCH] x86_64: double check the multi root bus with fam10h mmconf by Yinghai Lu on Thursday, March 6, 2008 - 2:15 am. (1 message)