quicklists confuse meminfo

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Thomas Gleixner
Date: Sunday, March 9, 2008 - 3:19 am

Bart reported http://bugzilla.kernel.org/show_bug.cgi?id=9991. He
assumed a memory leak in 32bit kernels when he analyzed the output of
/proc/meminfo.

The leak is not a leak, it's an accounting bug. quicklists keep a
large amount of pages which are accounted as used memory.

It can be easily observed by watching /proc/meminfo on an idle system
and then run

# while true; do ls >/dev/null; done

for a while. The amount of free memory decreases steadily to the
point, where the quicklist limit kicks in.

To verify this I added quicklists (patch below) to the /proc/meminfo
output and the decrease of free memory is matching the increase of the
memory which is kept in quicklists.

I'm not sure how we should handle the quicklist accounting, but the
current state of silently hiding the free memory in the quicklists is
definitely not acceptable.

Another strange observation about quicklists is the imbalance of the
quicklists across CPUs. Running the above loop on a 2way machine I can
observe that the quicklist pages are acuumulating on one CPU. Stopping
and restarting the loop a couple of times can shift the accumulation
from one to the other CPU.

Thanks,
	tglx

---
 fs/proc/proc_misc.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Index: linux-2.6/fs/proc/proc_misc.c
===================================================================
--- linux-2.6.orig/fs/proc/proc_misc.c
+++ linux-2.6/fs/proc/proc_misc.c
@@ -49,6 +49,8 @@
 #include <linux/crash_dump.h>
 #include <linux/pid_namespace.h>
 #include <linux/bootmem.h>
+#include <linux/quicklist.h>
+
 #include <asm/uaccess.h>
 #include <asm/pgtable.h>
 #include <asm/io.h>
@@ -183,8 +185,11 @@ static int meminfo_read_proc(char *page,
 		"Committed_AS: %8lu kB\n"
 		"VmallocTotal: %8lu kB\n"
 		"VmallocUsed:  %8lu kB\n"
-		"VmallocChunk: %8lu kB\n",
-		K(i.totalram),
+		"VmallocChunk: %8lu kB\n"
+#ifdef CONFIG_QUICKLIST
+		"QuickLists:   %8lu kB\n"
+#endif
+		,K(i.totalram),
 		K(i.freeram),
 		K(i.bufferram),
 		K(cached),
@@ -215,6 +220,9 @@ static int meminfo_read_proc(char *page,
 		(unsigned long)VMALLOC_TOTAL >> 10,
 		vmi.used >> 10,
 		vmi.largest_chunk >> 10
+#ifdef CONFIG_QUICKLIST
+		,K(quicklist_total_size())
+#endif
 		);
 
 		len += hugetlb_report_meminfo(page + len);

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
quicklists confuse meminfo, Thomas Gleixner, (Sun Mar 9, 3:19 am)
Re: quicklists confuse meminfo, Bart Van Assche, (Sun Mar 9, 3:26 am)
Re: quicklists confuse meminfo, Andi Kleen, (Sun Mar 9, 3:29 am)
Re: quicklists confuse meminfo, KOSAKI Motohiro, (Sun Mar 9, 3:42 am)
Re: quicklists confuse meminfo, Ingo Molnar, (Sun Mar 9, 4:14 am)
Re: quicklists confuse meminfo, Thomas Gleixner, (Sun Mar 9, 4:56 am)
Re: quicklists confuse meminfo, Thomas Gleixner, (Sun Mar 9, 5:00 am)
Re: quicklists confuse meminfo, Ingo Molnar, (Sun Mar 9, 5:01 am)
Re: quicklists confuse meminfo, Johannes Weiner, (Sun Mar 9, 5:03 am)
Re: quicklists confuse meminfo, KOSAKI Motohiro, (Sun Mar 9, 5:03 am)
Re: quicklists confuse meminfo, Ingo Molnar, (Sun Mar 9, 5:09 am)
Re: quicklists confuse meminfo, Ingo Molnar, (Sun Mar 9, 5:34 am)
Re: quicklists confuse meminfo, KOSAKI Motohiro, (Sun Mar 9, 5:47 am)
Re: quicklists confuse meminfo, Andi Kleen, (Sun Mar 9, 5:49 am)
Re: quicklists confuse meminfo, KOSAKI Motohiro, (Sun Mar 9, 5:51 am)
Re: quicklists confuse meminfo, Thomas Gleixner, (Sun Mar 9, 6:20 am)
Re: quicklists confuse meminfo, Andrew Morton, (Sun Mar 9, 11:46 am)
Re: quicklists confuse meminfo, Arjan van de Ven, (Sun Mar 9, 12:11 pm)
Re: quicklists confuse meminfo, Ingo Molnar, (Sun Mar 9, 12:25 pm)
Re: quicklists confuse meminfo, Ingo Molnar, (Sun Mar 9, 12:27 pm)
Re: quicklists confuse meminfo, Ingo Molnar, (Sun Mar 9, 12:31 pm)
Re: quicklists confuse meminfo, Andi Kleen, (Sun Mar 9, 1:21 pm)
Re: quicklists confuse meminfo, Christoph Lameter, (Mon Mar 10, 8:51 am)
Re: quicklists confuse meminfo, Christoph Lameter, (Mon Mar 10, 8:54 am)
Re: quicklists confuse meminfo, Christoph Lameter, (Mon Mar 10, 8:55 am)
Re: quicklists confuse meminfo, Christoph Lameter, (Mon Mar 10, 8:57 am)
Re: quicklists confuse meminfo, Andi Kleen, (Mon Mar 10, 9:43 am)
Re: quicklists confuse meminfo, Hugh Dickins, (Mon Mar 10, 10:19 am)
Re: quicklists confuse meminfo, Andi Kleen, (Mon Mar 10, 10:25 am)
Re: quicklists confuse meminfo, Jeremy Fitzhardinge, (Mon Mar 10, 10:31 am)
Re: quicklists confuse meminfo, Andi Kleen, (Mon Mar 10, 10:53 am)
Re: quicklists confuse meminfo, Jeremy Fitzhardinge, (Mon Mar 10, 11:35 am)
Re: quicklists confuse meminfo, Andi Kleen, (Mon Mar 10, 12:06 pm)
Re: quicklists confuse meminfo, H. Peter Anvin, (Mon Mar 10, 1:54 pm)
Re: quicklists confuse meminfo, Jeremy Fitzhardinge, (Mon Mar 10, 2:26 pm)
Re: quicklists confuse meminfo, Nick Piggin, (Mon Mar 10, 9:07 pm)
Re: quicklists confuse meminfo, Bart Van Assche, (Fri Mar 21, 5:52 am)
Re: quicklists confuse meminfo, Ingo Molnar, (Fri Mar 21, 7:45 am)
Re: quicklists confuse meminfo, Bart Van Assche, (Wed Mar 26, 12:45 am)
Re: quicklists confuse meminfo, Andrew Morton, (Wed Mar 26, 12:53 am)
Re: quicklists confuse meminfo, Ingo Molnar, (Wed Mar 26, 1:13 am)
Re: quicklists confuse meminfo, Bart Van Assche, (Wed Mar 26, 3:37 am)
Re: quicklists confuse meminfo, Christoph Lameter, (Wed Mar 26, 9:34 am)
Re: quicklists confuse meminfo, Bart Van Assche, (Thu Mar 27, 2:48 am)