Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rafael J. Wysocki
Date: Tuesday, April 1, 2008 - 2:50 pm

On Tuesday, 1 of April 2008, Alan Stern wrote:

No, it has more pointers.  Specifically, it is like

struct pm_ext_ops {
	struct pm_ops base;
	--additional pointers go here--
}
 

Yes, it does.  In that cases, the error code would tell the PM core not to attempt
to resume the device's children etc.  Otherwise, it's quite meaningless to the
PM core, because it really can mean anything and how's the PM core supposed
to handle _that_?

Either we decide that the error codes returned by ->resume() mean critical
errors or there's no point in returning error codes from ->resume() at all
(other than logging the errors by the core).

Well, that's getting confused.  I think I'll have to rework the patch not to
really handle the errors returned by ->resume() and friends, after all, but
I'll keep the reporting of them.

However, I'd like to add a recommendation that the _new_ "resume" callbacks
should only return errors in critical situations as the indication to the PM
core that something went _really_ wrong and the device in question is quite
surely unusable.

Thanks,
Rafael
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH 0/3] PM: Rework suspend and hibernation code f ..., Rafael J. Wysocki, (Sat Mar 29, 3:17 pm)
[RFC][PATCH 1/3] PM: Introduce new top level suspend and h ..., Rafael J. Wysocki, (Sat Mar 29, 3:20 pm)
[RFC][PATCH 2/3] PM: New suspend and hibernation callbacks ..., Rafael J. Wysocki, (Sat Mar 29, 3:22 pm)
[RFC][PATCH 3/3] PM: New suspend and hibernation callbacks ..., Rafael J. Wysocki, (Sat Mar 29, 3:23 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Rafael J. Wysocki, (Sat Mar 29, 7:54 pm)
Re: [RFC][PATCH 2/3] PM: New suspend and hibernation callb ..., Rafael J. Wysocki, (Sat Mar 29, 7:56 pm)
[RFC][PATCH] PM: Introduce new top level suspend and hiber ..., Rafael J. Wysocki, (Mon Mar 31, 2:29 pm)
Re: [RFC][PATCH] PM: Introduce new top level suspend and h ..., Benjamin Herrenschmidt, (Tue Apr 1, 1:27 am)
Re: [RFC][PATCH] PM: Introduce new top level suspend and h ..., Rafael J. Wysocki, (Tue Apr 1, 2:50 pm)