Re: [PATCH] Replace completions with semaphores

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Ingo Molnar

Subject: Re: [PATCH] Replace completions with semaphores

Date: Sunday, April 13, 2008 - 12:08 am

* Matthew Wilcox <matthew@wil.cx> wrote:

quoted text> Yes, that text appears in the URL I provided in the mail that started 
> this thread ;-)
> 
> The semaphore rewrite I did does not have this problem (it's less 
> efficient than the hand-optimised assembler, but much more 
> maintainable). You're supposed to be using mutexes if you want 
> efficiency anyway.

but semaphores will be _removed_, _completely_. Rewriting them in 
generic C code is just the first step towards that - it consolidates all 
the myriads of semaphore implementations that Linux has spread out.

your proposed change to change completions to semaphores is totally 
backwards and prolongs an API we want to get rid of. Did you miss this 
aspect of the mutex rewrite, of the semaphore-to-mutex, 
semaphore-to-completions and semaphore-to-rwsem conversions?

	Ingo
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] Replace completions with semaphores, Matthew Wilcox, (Fri Apr 11, 2:00 pm)

Re: [PATCH] Replace completions with semaphores, Daniel Walker, (Fri Apr 11, 11:43 pm)

Re: [PATCH] Replace completions with semaphores, Ingo Oeser, (Sat Apr 12, 3:31 am)

Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Sat Apr 12, 5:24 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sat Apr 12, 10:26 am)

Re: [PATCH] Replace completions with semaphores, Daniel Walker, (Sat Apr 12, 11:01 am)

Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Sat Apr 12, 11:05 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sat Apr 12, 12:04 pm)

Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Sat Apr 12, 12:16 pm)

Re: [PATCH] Replace completions with semaphores, Roland Dreier, (Sat Apr 12, 12:53 pm)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sat Apr 12, 1:47 pm)

Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Sun Apr 13, 12:05 am)

Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Sun Apr 13, 12:08 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sun Apr 13, 5:52 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sun Apr 13, 5:57 am)

Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Sun Apr 13, 6:55 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sun Apr 13, 7:22 am)

Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Sun Apr 13, 7:55 am)

Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Mon Apr 14, 8:39 am)

Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Mon Apr 14, 8:41 am)

Re: [PATCH] Replace completions with semaphores, Roland Dreier, (Mon Apr 14, 8:58 am)

Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Mon Apr 14, 9:32 am)

Re: [PATCH] Replace completions with semaphores, Jens Axboe, (Mon Apr 14, 9:54 am)

Re: [PATCH] Replace completions with semaphores, Arjan van de Ven, (Mon Apr 14, 9:56 am)

Re: API documentation (was [PATCH] Replace completions wit ..., Jonathan Corbet, (Mon Apr 14, 10:12 am)

Re: API documentation (was [PATCH] Replace completions wit ..., Peter Zijlstra, (Mon Apr 14, 10:33 am)

Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Mon Apr 14, 10:46 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Mon Apr 14, 10:46 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Mon Apr 14, 10:50 am)

Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Mon Apr 14, 10:54 am)

Re: [PATCH] Replace completions with semaphores, Daniel Walker, (Mon Apr 14, 11:09 am)

Re: API documentation (was [PATCH] Replace completions wit ..., Bart Van Assche, (Mon Apr 14, 11:38 am)

Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Mon Apr 14, 12:16 pm)

Re: [PATCH] Replace completions with semaphores, Alan Cox, (Mon Apr 14, 12:16 pm)

Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Mon Apr 14, 11:18 pm)

Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Mon Apr 14, 11:46 pm)

Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Tue Apr 15, 12:17 am)

Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Tue Apr 15, 1:44 am)

Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Tue Apr 15, 6:15 am)

Re: [PATCH] Replace completions with semaphores, Linus Torvalds, (Tue Apr 15, 9:09 am)

Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Tue Apr 15, 9:27 am)

Re: [PATCH] Replace completions with semaphores, Linus Torvalds, (Tue Apr 15, 9:57 am)

Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Tue Apr 15, 10:05 am)

Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Tue Apr 15, 10:15 am)

Re: [PATCH] Replace completions with semaphores, Linus Torvalds, (Tue Apr 15, 10:26 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Tue Apr 15, 10:41 am)

Re: [PATCH] Replace completions with semaphores, Linus Torvalds, (Tue Apr 15, 11:14 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Tue Apr 15, 11:50 am)

Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Wed Apr 16, 5:37 am)

Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Wed Apr 16, 5:50 am)

Killable stat/readdir, Matthew Wilcox, (Wed Apr 16, 5:59 am)

Re: [PATCH] Replace completions with semaphores, Ingo Oeser, (Wed Apr 16, 9:07 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 9:16 am)

Re: [PATCH] Replace completions with semaphores, Oliver Neukum, (Wed Apr 16, 9:31 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 9:34 am)

Re: [PATCH] Replace completions with semaphores, Oliver Neukum, (Wed Apr 16, 9:42 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 9:44 am)

Re: [PATCH] Replace completions with semaphores, Roland Dreier, (Wed Apr 16, 9:47 am)

Re: [PATCH] Replace completions with semaphores, Arjan van de Ven, (Wed Apr 16, 9:50 am)

Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 9:58 am)

Re: [PATCH] Repla