Home » Mailing list archives » linux-kernel » 2008 » April » 23

[2.6 patch] net/mac80211/rx.c: fix off-by-one

Previous thread: [2.6 patch] scsi/FlashPoint.c: fix off-by-one errors by Adrian Bunk on Wednesday, April 23, 2008 - 2:51 am. (1 message)

Next thread: [2.6 patch] drivers/of/of_i2c.c: add MODULE_LICENSE by Adrian Bunk on Wednesday, April 23, 2008 - 2:51 am. (2 messages)
[view original message]
From: Adrian Bunk
Subject: [2.6 patch] net/mac80211/rx.c: fix off-by-one
Date: Wednesday, April 23, 2008 - 2:51 am

This patch fixes an off-by-one in net/mac80211/rx.c introduced by
commit 8318d78a44d49ac1edf2bdec7299de3617c4232e
(cfg80211 API for channels/bitrates, mac80211 and driver conversion)
and spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
--- linux-2.6/net/mac80211/rx.c.old	2008-04-22 02:23:40.000000000 +0300
+++ linux-2.6/net/mac80211/rx.c	2008-04-22 02:24:23.000000000 +0300
@@ -2168,11 +2168,11 @@ void __ieee80211_rx(struct ieee80211_hw 
 	u32 pkt_load;
 	struct ieee80211_rate *rate = NULL;
 	struct ieee80211_supported_band *sband;
 
 	if (status->band < 0 ||
-	    status->band > IEEE80211_NUM_BANDS) {
+	    status->band >= IEEE80211_NUM_BANDS) {
 		WARN_ON(1);
 		return;
 	}
 
 	sband = local->hw.wiphy->bands[status->band];

--


[ message continues ]
Previous thread: [2.6 patch] scsi/FlashPoint.c: fix off-by-one errors by Adrian Bunk on Wednesday, April 23, 2008 - 2:51 am. (1 message)

Next thread: [2.6 patch] drivers/of/of_i2c.c: add MODULE_LICENSE by Adrian Bunk on Wednesday, April 23, 2008 - 2:51 am. (2 messages)