[PATCH] ide: manage resources for PCI devices in ide_pci_enable() (take 3)

Previous thread: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc() by Andi Kleen on Saturday, April 26, 2008 - 1:02 pm. (8 messages)

Next thread: by Davi Leal on Saturday, April 26, 2008 - 1:28 pm. (1 message)
From: Bartlomiej Zolnierkiewicz
Date: Saturday, April 26, 2008 - 1:18 pm

* Reserve PCI BARs 0-3 (0-1 for single port controllers) in
  ide_pci_enable() and remove ide_hwif_request_regions() call
  from ide_device_add_all() (also cleanup resource management
  in scc_pata host driver).

* Fix handling of PCI BAR 4 in ide_pci_enable(), then cleanup
  ide_iomio_dma() (+ init_hwif_trm290() in trm290 host driver)
  and remove ide_release[_iomio]_dma().

v2:
* Fixup trm290 host driver.

v3:
* Because of scc_pata host driver changes we need to call
  pci_request_selected_regions() also in setup_mmio_scc().

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
replacement patch

 drivers/ide/ide-dma.c      |   43 +++----------------------------------------
 drivers/ide/ide-probe.c    |    6 ------
 drivers/ide/ide.c          |    2 +-
 drivers/ide/pci/scc_pata.c |   31 +++++++++----------------------
 drivers/ide/pci/trm290.c   |    6 ------
 drivers/ide/setup-pci.c    |   22 +++++++++++++++-------
 include/linux/ide.h        |    4 ++--
 7 files changed, 30 insertions(+), 84 deletions(-)

Index: b/drivers/ide/ide-dma.c
===================================================================
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -810,7 +810,7 @@ void ide_dma_timeout (ide_drive_t *drive
 
 EXPORT_SYMBOL(ide_dma_timeout);
 
-static void ide_release_dma_engine(ide_hwif_t *hwif)
+void ide_release_dma_engine(ide_hwif_t *hwif)
 {
 	if (hwif->dmatable_cpu) {
 		struct pci_dev *pdev = to_pci_dev(hwif->dev);
@@ -821,27 +821,6 @@ static void ide_release_dma_engine(ide_h
 	}
 }
 
-static int ide_release_iomio_dma(ide_hwif_t *hwif)
-{
-	release_region(hwif->dma_base, 8);
-	if (hwif->extra_ports)
-		release_region(hwif->extra_base, hwif->extra_ports);
-	return 1;
-}
-
-/*
- * Needed for allowing full modular support of ide-driver
- */
-int ide_release_dma(ide_hwif_t *hwif)
-{
-	ide_release_dma_engine(hwif);
-
-	if (hwif->mmio)
-		return 1;
-	else
-		return ide_release_iomio_dma(hwif);
-}
-
 static int ...
Previous thread: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc() by Andi Kleen on Saturday, April 26, 2008 - 1:02 pm. (8 messages)

Next thread: by Davi Leal on Saturday, April 26, 2008 - 1:28 pm. (1 message)