[09/12] USB: remove broken usb-serial num_endpoints check

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg KH
Date: Tuesday, April 29, 2008 - 11:49 am

2.6.24-stable review patch.  If anyone has any objections, please let us
know.

------------------

From: Greg Kroah-Hartman <gregkh@suse.de>

commit: 07c3b1a1001614442c665570942a3107a722c314

The num_interrupt_in, num_bulk_in, and other checks in the usb-serial
code are just wrong, there are too many different devices out there with
different numbers of endpoints.  We need to just be sticking with the
device ids instead of trying to catch this kind of thing.  It broke too
many different devices.

This fixes a large number of usb-serial devices to get them working
properly again.


Cc: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/usb/serial/usb-serial.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -844,6 +844,7 @@ int usb_serial_probe(struct usb_interfac
 	serial->num_interrupt_in = num_interrupt_in;
 	serial->num_interrupt_out = num_interrupt_out;
 
+#if 0
 	/* check that the device meets the driver's requirements */
 	if ((type->num_interrupt_in != NUM_DONT_CARE &&
 				type->num_interrupt_in != num_interrupt_in)
@@ -857,6 +858,7 @@ int usb_serial_probe(struct usb_interfac
 		kfree(serial);
 		return -EIO;
 	}
+#endif
 
 	/* found all that we need */
 	dev_info(&interface->dev, "%s converter detected\n",

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[00/12] 2.6.24-stable review, Greg KH, (Tue Apr 29, 11:49 am)
[01/12] splice: use mapping_gfp_mask, Greg KH, (Tue Apr 29, 11:49 am)
[02/12] fix oops on rmmod capidrv, Greg KH, (Tue Apr 29, 11:49 am)
[09/12] USB: remove broken usb-serial num_endpoints check, Greg KH, (Tue Apr 29, 11:49 am)
[10/12] V4L: Fix VIDIOCGAP corruption in ivtv, Greg KH, (Tue Apr 29, 11:50 am)
[11/12] V4L: cx88: enable radio GPIO correctly, Greg KH, (Tue Apr 29, 11:50 am)
Re: [00/12] 2.6.24-stable review, Jörg-Volker Peetz, (Tue Apr 29, 2:27 pm)
Re: [00/12] 2.6.24-stable review, Willy Tarreau, (Tue Apr 29, 3:45 pm)
Re: [00/12] 2.6.24-stable review, Darren Salt, (Tue Apr 29, 8:21 pm)
Re: [stable] [00/12] 2.6.24-stable review, Greg KH, (Wed Apr 30, 8:39 pm)
Re: [stable] [00/12] 2.6.24-stable review, Darren Salt, (Fri May 2, 8:24 am)
Re: [stable] [00/12] 2.6.24-stable review, Greg KH, (Thu May 8, 10:27 am)