Re: [PATCH] relay: add buffer-only functionality, allowing for early kernel tracing

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eduard - Gabriel Munteanu
Date: Friday, April 4, 2008 - 9:19 am

On Fri, 4 Apr 2008 12:06:23 -0400
Mathieu Desnoyers <compudj@krystal.dyndns.org> wrote:


Sure. I'm doing this as part of my GSoC application (well, I haven't
been accepted yet). I had also proposed this to Pekka Enberg, my
mentor, but he was reluctant to hack the relay code more invasively. Now
that you agree with this, I'll work on it.

kmalloc() doesn't work before kmem_cache_init() and relay code uses
kmalloc(), not vmalloc(), IIRC.

I would go another way. Have the relay client call __get_free_pages()
or similar function, allocate the buffer and pass it on to a variant of
relay_open(), let's name it relay_early_open(). __get_free_pages() can
be used before kmem_cache_init() as far as I know. No free is required,
since early tracing code implies it's built into the kernel and not as
a module. What do you say?

Will you merge this or wait until I finish the very early tracing stuff?

Cheers,
Eduard
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] relay: add buffer-only functionality, allowing for ..., Eduard - Gabriel Mun ..., (Fri Apr 4, 8:33 am)
Re: [PATCH] relay: add buffer-only functionality, allowing ..., Eduard - Gabriel Mun ..., (Fri Apr 4, 9:19 am)
Re: [PATCH] relay: add buffer-only functionality, allowing ..., Eduard - Gabriel Mun ..., (Fri Apr 4, 9:28 am)
Re: [PATCH] relay: add buffer-only functionality, allowing ..., Eduard - Gabriel Mun ..., (Fri Apr 4, 10:06 am)
Re: [PATCH] relay: add buffer-only functionality, allowing ..., Eduard - Gabriel Mun ..., (Sat Apr 5, 6:27 pm)