login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
14
Re: [PATCH] HSO: add option hso driver
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Greg KH
Subject:
Re: [PATCH] HSO: add option hso driver
Date: Tuesday, May 13, 2008 - 9:52 pm
On Tue, May 13, 2008 at 11:27:27PM +0100, Alan Cox wrote:
quoted text
> > Jeff, please queue this up for 2.6.27 if there are no problems that you > > can see. It has been in the linux-next tree for a while, and many users > > are reporting that it is working for them. > > > > Or if you feel it's ok for 2.6.26, I will not object to that either :) > > Can we get it into 2.6.26 - its a driver for new hardware and the driver > is going to get a clean up for 2.6.27 anyway. > > Comments below are minor and I don't think blockers > > So for the serial side > > Acked-by: Alan Cox <alan@redhat.com> > > > > + termios = serial->tty->termios; > > tty is passed why keep using serial->tty (hint: think about parallel > hangup versus close/open)
Ick, now fixed.
quoted text
> > +/* close the requested serial port */ > > +static void hso_serial_close(struct tty_struct *tty, struct file *filp) > > +{ > > + struct hso_serial *serial = tty->driver_data; > > + u8 usb_gone; > > + > > + D1("Closing serial port"); > > + > > + /* sanity check */ > > + if (tty == NULL || serial == NULL) { > > + D1("(tty == NULL || tty->driver_data == NULL)"); > > + return; > > + } > > tty cannot be NULL here
removed.
quoted text
> > +static int hso_serial_write(struct tty_struct *tty, const unsigned char *buf, > > + int count) > > +{ > > + struct hso_serial *serial = get_serial_by_tty(tty); > > + int space, tx_bytes; > > + unsigned long flags; > > + > > + /* sanity check */ > > + if (serial == NULL) { > > + printk(KERN_ERR "%s: tty or tty->driver_data is NULL\n", > > Checks one thing printks another 8)
Fixed.
quoted text
> > + /* the actual setup */ > > + spin_lock_irqsave(&serial->serial_lock, flags); > > + if (serial->open_count) > > + _hso_serial_set_termios(tty, old); > > (else *tty->termios = *old_termios)
Added. Thanks for the review, I really appreciate it. greg k-h --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] HSO: add option hso driver
, Greg KH
, (Tue May 13, 2:51 pm)
Re: [PATCH] HSO: add option hso driver
, Alan Cox
, (Tue May 13, 3:27 pm)
Re: [PATCH] HSO: add option hso driver
, Jeff Garzik
, (Tue May 13, 4:26 pm)
Re: [PATCH] HSO: add option hso driver
, Greg KH
, (Tue May 13, 6:58 pm)
Re: [PATCH] HSO: add option hso driver
, Greg KH
, (Tue May 13, 9:52 pm)
HSO: add option hso driver
, Greg Kroah-Hartman
, (Tue May 13, 9:57 pm)
Re: HSO: add option hso driver
, Paulius Zaleckas
, (Wed May 14, 6:59 am)
Re: HSO: add option hso driver
, Filip Aben
, (Wed May 14, 8:12 am)
Re: [PATCH] HSO: add option hso driver
, Jan Engelhardt
, (Wed May 14, 8:58 am)
Re: HSO: add option hso driver
, Marcel Holtmann
, (Wed May 14, 10:36 am)
Re: HSO: add option hso driver