Re: [patch 21/21] slab defrag: Obsolete SLAB

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Lameter
Date: Thursday, May 15, 2008 - 10:15 am

On Wed, 14 May 2008, Matt Mackall wrote:


Both allocators have a different design which leads to different behavior. 
I do not think the expectation that one must always best the other is 
reasonable or even possible.

I'd be glad if we had some means of increasing the performance in the 
currently known cases where remote slab free becomes an issue by avoiding 
the atomic op.

AFAICT we so far have been able to compensate for the additional atomic op 
with a reduced cache footprint and less complexity overall on remote frees 
and also through improvements in alloc behavior. I hope that the current 
improvements in 2.6.26 are sufficient to address the concerns with TP-C 
(which I do not have direct access to and frankly I know very little about 
the setup etc). We are still not sure exactly why TP-C has a problem. The 
slab statistics were added to figure that one out. We can get a view of 
what is going on without having access to the system.

I think the current way of compensating for that atomic op is better than 
getting back to the queue mess. Maybe there is a way of limited use of 
queues that avoids the atomic op but so far I have not 
found one. Maybe someone else looking at it will have better ideas.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Fri May 9, 8:08 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Andi Kleen, (Sat May 10, 2:53 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Rik van Riel, (Sat May 10, 7:15 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, KOSAKI Motohiro, (Mon May 12, 12:38 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Pekka Enberg, (Mon May 12, 12:54 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Andi Kleen, (Mon May 12, 3:08 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Pekka Enberg, (Mon May 12, 3:23 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 10:29 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 10:30 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Andi Kleen, (Wed May 14, 10:49 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 11:03 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 11:05 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matt Mackall, (Wed May 14, 11:18 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 12:21 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matt Mackall, (Wed May 14, 12:49 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 1:33 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 1:46 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matthew Wilcox, (Wed May 14, 1:58 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 2:00 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matt Mackall, (Wed May 14, 2:02 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matthew Wilcox, (Wed May 14, 2:21 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 2:26 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 2:33 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matthew Wilcox, (Wed May 14, 2:43 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 2:53 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matt Mackall, (Wed May 14, 2:54 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matthew Wilcox, (Wed May 14, 3:00 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 3:32 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Wed May 14, 3:34 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Zhang, Yanmin, (Wed May 14, 8:26 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Thu May 15, 10:05 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Thu May 15, 10:15 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matthew Wilcox, (Thu May 15, 10:49 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Thu May 15, 10:58 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matthew Wilcox, (Thu May 15, 11:13 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Eric Dumazet, (Thu May 15, 11:19 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Vegard Nossum, (Thu May 15, 11:29 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Thu May 15, 11:43 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matthew Wilcox, (Thu May 15, 11:51 am)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Thu May 15, 12:09 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matthew Wilcox, (Thu May 15, 12:29 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Matthew Wilcox, (Thu May 15, 1:14 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Pekka Enberg, (Thu May 15, 1:30 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Zhang, Yanmin, (Thu May 15, 10:16 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Fri May 16, 12:06 pm)
Re: [patch 21/21] slab defrag: Obsolete SLAB, Christoph Lameter, (Fri May 16, 12:17 pm)