Re: [patch 04/41] cpu ops: Core piece for generic atomic per cpu operations | KernelTrap

Re: [patch 04/41] cpu ops: Core piece for generic atomic per cpu operations

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Rusty Russell

Subject: Re: [patch 04/41] cpu ops: Core piece for generic atomic per cpu operations

Date: Friday, May 30, 2008 - 12:05 am

On Friday 30 May 2008 15:38:25 Andrew Morton wrote:
quoted text> On Thu, 29 May 2008 22:17:55 -0700 (PDT) Christoph Lameter 
<clameter@sgi.com> wrote:
quoted text> > But then its related to percpu operations and relies extensively on the
> > various percpu.h files in asm-generic and asm-arch and include/linux
>
> Well that should be fixed.  We should never have mixed the
> alloc_percpu() and DEFINE_PER_CPU things inthe same header.  They're
> different.
>
> otoh as you propose removing the old alloc_percpu() I guess the end
> result is no worse than what we presently have.

No, the worst thing is that this is a great deal of churn which doesn't 
actually fix the "running out of per-cpu memory" problem.

It can, and should, be fixed, before changing dynamic percpu alloc to use the 
same percpu pool.

Rusty.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 04/41] cpu ops: Core piece for generic atomic per c ..., Christoph Lameter, (Thu May 29, 8:56 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Andrew Morton, (Thu May 29, 9:58 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Thu May 29, 10:17 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Andrew Morton, (Thu May 29, 10:38 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Thu May 29, 11:12 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Thu May 29, 11:32 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Fri May 30, 12:05 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Fri May 30, 12:08 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Fri May 30, 11:00 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Sun Jun 1, 7:00 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Mike Travis, (Wed Jun 4, 11:18 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Thu Jun 5, 4:59 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Mon Jun 9, 12:00 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Mon Jun 9, 4:09 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Mon Jun 9, 4:27 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Mon Jun 9, 4:54 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Mon Jun 9, 7:56 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Mon Jun 9, 8:18 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Tue Jun 10, 10:42 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Tue Jun 10, 5:03 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Tue Jun 10, 5:15 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Wed Jun 11, 4:10 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Wed Jun 11, 4:39 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Nick Piggin, (Wed Jun 11, 5:58 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Wed Jun 11, 7:44 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Nick Piggin, (Wed Jun 11, 8:40 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Martin Peschke, (Thu Jun 12, 2:37 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Nick Piggin, (Thu Jun 12, 4:21 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Thu Jun 12, 10:19 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Thu Jun 12, 5:38 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Thu Jun 12, 7:27 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Sun Jun 15, 3:33 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Christoph Lameter, (Mon Jun 16, 7:52 am)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ..., Rusty Russell, (Mon Jun 16, 5:24 pm)

Re: [patch 04/41] cpu ops: Core piece for generic atomic p ...