Re: Linux 2.6.26-rc1

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Stefan Richter
Date: Tuesday, May 6, 2008 - 4:36 pm

Mauro Carvalho Chehab wrote:
    ^^^^

Yes...  Except that it is very dangerous to /move/ dependencies, as you 
are apparently doing in that patch.  When you use "select" somewhere, 
you should generally /copy/ dependencies.

Although something like

config VIRTUAL_META_OPTION
	depends on REAL_DEPENDENCY

config THE_REAL_THING
	depends on VIRTUAL_META_OPTION

does work if THE_REAL_THING actually depends on REAL_DEPENDENCY, it is 
safer if this dependency stays there, i.e.

config THE_REAL_THING
	depends on REAL_DEPENDECY

or

config THE_REAL_THING
	depends on REAL_DEPENDENCY && VIRTUAL_META_OPTION

or whatever, or equivalent constructs involving "if"..."endif".

(I presume that for example MEDIA_TUNER_TDA827X does indeed have a build 
dependency on DVB_CORE && I2C.)

Or in other words:

Since MEDIA_TUNER selects a bunch of options which itself have build 
dependencies, you /must/ duplicate all of their dependencies to 
MEDIA_TUNER.  Well, actually you don't use plain "select", you use 
"select ... if !MEDIA_TUNER_CUSTOMIZE".  So if you can ensure by other 
means that those 2nd level dependencies are guaranteed to be fulfilled 
whenever MEDIA_TUNER_CUSTOMIZE=n, then you don't need to duplicate the 
2nd level dependencies into MEDIA_TUNER.

That's the same what I meant in my comment on VIDEO_HELPER_CHIPS_AUTO:

Those options which "select" video decoders generally /must/ contain 
duplicates of the dependency statements of the decoders which they 
select.  Except, since you don't use plain "select" there but actually 
"select ... if VIDEO_HELPER_CHIPS_AUTO", you can alternatively put the 
duplicates of the dependency statements to VIDEO_HELPER_CHIPS_AUTO.
-- 
Stefan Richter
-=====-==--- -=-= --===
http://arcgraph.de/sr/
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.26-rc1, Linus Torvalds, (Sat May 3, 12:38 pm)
Re: Linux 2.6.26-rc1, Alistair John Strachan, (Sat May 3, 2:47 pm)
Re: Linux 2.6.26-rc1, Alistair John Strachan, (Sat May 3, 2:53 pm)
[patch] sysfs: build fix, Ingo Molnar, (Sun May 4, 12:29 am)
Re: Linux 2.6.26-rc1, Robin Holt, (Sun May 4, 5:30 am)
Re: Linux 2.6.26-rc1, Alistair John Strachan, (Sun May 4, 6:56 am)
Re: Linux 2.6.26-rc1, Robin Holt, (Sun May 4, 9:09 am)
Re: Linux 2.6.26-rc1, Alistair John Strachan, (Sun May 4, 9:33 am)
Re: Linux 2.6.26-rc1, Jan Engelhardt, (Sun May 4, 11:40 am)
Re: Linux 2.6.26-rc1, Andreas Mohr, (Sun May 4, 10:39 pm)
Re: Linux 2.6.26-rc1, Ingo Molnar, (Mon May 5, 12:30 am)
Re: Linux 2.6.26-rc1, Mauro Carvalho Chehab, (Mon May 5, 1:14 pm)
Re: Linux 2.6.26-rc1, Mauro Carvalho Chehab, (Mon May 5, 2:04 pm)
Re: Linux 2.6.26-rc1, Stephen Rothwell, (Mon May 5, 4:51 pm)
Re: Linux 2.6.26-rc1, David Miller, (Mon May 5, 4:55 pm)
Re: Linux 2.6.26-rc1, Andrew Morton, (Mon May 5, 5:16 pm)
Re: Linux 2.6.26-rc1, Ingo Molnar, (Mon May 5, 5:17 pm)
Re: Linux 2.6.26-rc1, Ingo Molnar, (Mon May 5, 5:21 pm)
Re: Linux 2.6.26-rc1, Stephen Rothwell, (Mon May 5, 10:35 pm)
Re: Linux 2.6.26-rc1, Stephen Rothwell, (Mon May 5, 10:48 pm)
Re: Linux 2.6.26-rc1, Stephen Rothwell, (Mon May 5, 10:57 pm)
Re: Linux 2.6.26-rc1, David Miller, (Mon May 5, 11:56 pm)
Re: Linux 2.6.26-rc1, Stephen Rothwell, (Tue May 6, 12:26 am)
Re: Linux 2.6.26-rc1, Alistair John Strachan, (Tue May 6, 1:02 am)
Re: Linux 2.6.26-rc1, Mauro Carvalho Chehab, (Tue May 6, 3:31 am)
Re: Linux 2.6.26-rc1, Ingo Molnar, (Tue May 6, 6:07 am)
Re: Scheduling problems ? [ Was: Linux 2.6.26-rc1 ], Ingo Molnar, (Tue May 6, 6:11 am)
Re: Linux 2.6.26-rc1, Stefan Richter, (Tue May 6, 7:34 am)
Re: Linux 2.6.26-rc1, Stefan Richter, (Tue May 6, 7:54 am)
Re: Linux 2.6.26-rc1, Mauro Carvalho Chehab, (Tue May 6, 12:13 pm)
Re: Linux 2.6.26-rc1, Stefan Richter, (Tue May 6, 12:44 pm)
Re: Linux 2.6.26-rc1, Mauro Carvalho Chehab, (Tue May 6, 1:06 pm)
Re: Linux 2.6.26-rc1, Stefan Richter, (Tue May 6, 1:47 pm)
Re: Linux 2.6.26-rc1, Mauro Carvalho Chehab, (Tue May 6, 3:39 pm)
Re: Linux 2.6.26-rc1, Stefan Richter, (Tue May 6, 4:36 pm)
Re: Linux 2.6.26-rc1, Stefan Richter, (Tue May 6, 4:48 pm)
Re: Linux 2.6.26-rc1, Ingo Molnar, (Wed May 7, 1:35 am)
Re: Linux 2.6.26-rc1, Mauro Carvalho Chehab, (Thu May 8, 5:48 am)
Re: Linux 2.6.26-rc1, Stefan Richter, (Thu May 8, 7:11 am)