login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
15
Re: [PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Bartlomiej Zolnierkiewicz
Subject:
Re: [PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
Date: Sunday, June 15, 2008 - 7:57 am
On Sunday 15 June 2008, Borislav Petkov wrote:
quoted text
> On Sat, Jun 14, 2008 at 07:40:22PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Thursday 12 June 2008, Borislav Petkov wrote: > > > This is the first one in the series attempting to phase out ide_atapi_pc and use > > > block request structs. Also, the pc request type is now REQ_TYPE_BLOCK_PC. As a result, > > > idefloppy_blockpc_cmd becomes unused and can go. > > > > Do not attack too many dragons at once or they will slay you... ;) > > > > IOW this patch mixes too many changes (some _really_ non-trivial) > > in one go which results in rather bad outcome... > > yeah, this was more of a RFC patch for me not intended in any way for submission > but instead to get your comments on it. Atapi-land is full of surprises and you > have to be _really_ careful when changing stuff around. I got bitten by that > couple times when preparing those patches. Anyways, don't take those seriously, > they were simply a warmup :).
I'm not worried at all - I'm sure that if you keep fighting these dragons one by one they won't stand a chance... :) --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 00/18] misc generic ide stuff
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 01/18] ide-cd: remove wait-for-idle-controller bit ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 02/18] ide-cd: remove ide_cd_drain_data and ide_cd_ ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 03/18] ide-cd: cdrom_decode_status: factor out bloc ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 04/18] ide-cd: cdrom_decode_status: factor out fs r ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 05/18] ide-cd: ide_do_rw_cdrom: add the catch-all b ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 06/18] ide-cd: cdrom_start_seek: remove unused argu ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 07/18] ide-cd: mv ide_do_rw_cdrom ide_cd_do_request
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 08/18] ide-cd: simplify request issuing path
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 09/18] ide-cd: fold cdrom_start_seek into ide_cd_do ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 10/18] ide-cd: move request prep from cdrom_start_s ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 11/18] ide-cd: move request prep from cdrom_start_r ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 12/18] ide-cd: move request prep chunk from cdrom_d ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 14/18] ide-floppy: fold idefloppy_create_test_unit_ ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 15/18] ide-floppy: zero out the whole struct ide_at ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 16/18] ide-floppy: pass rq instead of pc to ideflop ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 17/18] ide-floppy: cleanup idefloppy_create_rw_cmd
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 18/18] ide: use flags in IRQ handler
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
Re: [PATCH 00/18] misc generic ide stuff
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:29 am)
Re: [PATCH 02/18] ide-cd: remove ide_cd_drain_data and ide ...
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:29 am)
Re: [PATCH 03/18] ide-cd: cdrom_decode_status: factor out ...
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:29 am)
Re: [PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:40 am)
Re: [PATCH 18/18] ide: use flags in IRQ handler
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:47 am)
Re: [PATCH 02/18] ide-cd: remove ide_cd_drain_data and ide ...
, Borislav Petkov
, (Sun Jun 15, 2:28 am)
Re: [PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
, Borislav Petkov
, (Sun Jun 15, 3:21 am)
Re: [PATCH 00/18] misc generic ide stuff
, Borislav Petkov
, (Sun Jun 15, 3:27 am)
Re: [PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
, Bartlomiej Zolnierki ...
, (Sun Jun 15, 7:57 am)
Re: [PATCH 03/18] ide-cd: cdrom_decode_status: factor out ...
, Borislav Petkov
, (Fri Aug 15, 12:34 am)
Re: [PATCH 03/18] ide-cd: cdrom_decode_status: factor out ...
, Borislav Petkov
, (Fri Aug 15, 12:34 am)
Re: [PATCH 03/18] ide-cd: cdrom_decode_status: factor out ...
, Borislav Petkov
, (Sat Aug 16, 1:26 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
<