[PATCH 01/50] KVM: remove long -> void *user -> long cast

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Avi Kivity
Date: Thursday, June 26, 2008 - 5:27 am

From: Christian Borntraeger <borntraeger@de.ibm.com>

kvm_dev_ioctl casts the arg value to void __user *, just to recast it
again to long. This seems unnecessary.

According to objdump the binary code on x86 is unchanged by this patch.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Avi Kivity <avi@qumranet.com>
---
 virt/kvm/kvm_main.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 2d29e26..764d702 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1179,7 +1179,6 @@ static int kvm_dev_ioctl_create_vm(void)
 static long kvm_dev_ioctl(struct file *filp,
 			  unsigned int ioctl, unsigned long arg)
 {
-	void __user *argp = (void __user *)arg;
 	long r = -EINVAL;
 
 	switch (ioctl) {
@@ -1196,7 +1195,7 @@ static long kvm_dev_ioctl(struct file *filp,
 		r = kvm_dev_ioctl_create_vm();
 		break;
 	case KVM_CHECK_EXTENSION:
-		r = kvm_dev_ioctl_check_extension((long)argp);
+		r = kvm_dev_ioctl_check_extension(arg);
 		break;
 	case KVM_GET_VCPU_MMAP_SIZE:
 		r = -EINVAL;
-- 
1.5.6

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 01/50] KVM: remove long -> void *user -> long cast, Avi Kivity, (Thu Jun 26, 5:27 am)
[PATCH 06/50] KVM: add missing kvmtrace bits, Avi Kivity, (Thu Jun 26, 5:27 am)
[PATCH 07/50] KVM: SVM: add missing kvmtrace markers, Avi Kivity, (Thu Jun 26, 5:27 am)
[PATCH 10/50] KVM: PIT: support mode 3, Avi Kivity, (Thu Jun 26, 5:27 am)
[PATCH 18/50] KVM: IOAPIC/LAPIC: Enable NMI support, Avi Kivity, (Thu Jun 26, 5:28 am)
[PATCH 21/50] KVM: MTRR support, Avi Kivity, (Thu Jun 26, 5:28 am)
[PATCH 28/50] KVM: MMU: Optimize prefetch_page(), Avi Kivity, (Thu Jun 26, 5:28 am)
[PATCH 32/50] KVM: MMU: Avoid page prefetch on SVM, Avi Kivity, (Thu Jun 26, 5:28 am)
[PATCH 40/50] KVM: Support mixed endian machines, Avi Kivity, (Thu Jun 26, 5:28 am)
[PATCH 50/50] KVM: MMU: Fix printk format, Avi Kivity, (Thu Jun 26, 5:28 am)