Home » Mailing list archives » linux-kernel » 2008 » July » 1

Re: [PATCH 3/3] Add timeout feature

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Hellwig
Subject: Re: [PATCH 3/3] Add timeout feature
Date: Tuesday, July 1, 2008 - 1:10 am

I still disagree with this whole patch.  There is not reason to let
the freeze request timeout - an auto-unfreezing will only confuse the
hell out of the caller.  The only reason where the current XFS freeze
call can hang and this would be theoretically useful is when the
filesystem is already frozen by someone else, but this should be fixed
by refusing to do the second freeze, as suggested in my comment to patch
1.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 3/3] Add timeout feature, Takashi Sato, (Mon Jun 30, 5:24 am)
Re: [PATCH 3/3] Add timeout feature, Christoph Hellwig, (Tue Jul 1, 1:10 am)
Re: [dm-devel] Re: [PATCH 3/3] Add timeout feature, Alasdair G Kergon, (Tue Jul 1, 3:52 am)
Re: [dm-devel] Re: [PATCH 3/3] Add timeout feature, Takashi Sato, (Thu Jul 3, 5:11 am)
Re: [dm-devel] Re: [PATCH 3/3] Add timeout feature, Alasdair G Kergon, (Thu Jul 3, 5:47 am)
Re: [dm-devel] Re: [PATCH 3/3] Add timeout feature, Eric Sandeen, (Thu Jul 3, 7:45 am)
Re: [dm-devel] Re: [PATCH 3/3] Add timeout feature, Dave Chinner, (Thu Jul 3, 3:11 pm)
Re: [dm-devel] Re: [PATCH 3/3] Add timeout feature, Takashi Sato, (Fri Jul 4, 5:08 am)
Re: [PATCH 3/3] Add timeout feature, Pavel Machek, (Mon Jul 7, 4:07 am)
Re: [PATCH 3/3] Add timeout feature, Dave Chinner, (Tue Jul 8, 4:10 pm)
Re: [PATCH 3/3] Add timeout feature, Pavel Machek, (Tue Jul 8, 4:20 pm)
Re: [PATCH 3/3] Add timeout feature, Dave Chinner, (Tue Jul 8, 5:52 pm)
Re: [PATCH 3/3] Add timeout feature, Theodore Tso, (Tue Jul 8, 6:09 pm)
Re: [PATCH 3/3] Add timeout feature, Brad Boyer, (Tue Jul 8, 9:21 pm)
Re: [PATCH 3/3] Add timeout feature, Miklos Szeredi, (Tue Jul 8, 11:13 pm)
Re: [PATCH 3/3] Add timeout feature, Christoph Hellwig, (Tue Jul 8, 11:16 pm)
Re: [PATCH 3/3] Add timeout feature, Miklos Szeredi, (Tue Jul 8, 11:22 pm)
Re: [PATCH 3/3] Add timeout feature, Arjan van de Ven, (Tue Jul 8, 11:41 pm)
Re: [PATCH 3/3] Add timeout feature, Miklos Szeredi, (Tue Jul 8, 11:48 pm)
Re: [PATCH 3/3] Add timeout feature, Arjan van de Ven, (Tue Jul 8, 11:55 pm)
Re: [PATCH 3/3] Add timeout feature, Dave Chinner, (Tue Jul 8, 11:59 pm)
Re: [PATCH 3/3] Add timeout feature, Miklos Szeredi, (Wed Jul 9, 12:08 am)
Re: [PATCH 3/3] Add timeout feature, Miklos Szeredi, (Wed Jul 9, 12:13 am)
Re: [PATCH 3/3] Add timeout feature, Dave Chinner, (Wed Jul 9, 12:13 am)
Re: [PATCH 3/3] Add timeout feature, Dave Chinner, (Wed Jul 9, 12:33 am)
Re: [PATCH 3/3] Add timeout feature, Miklos Szeredi, (Wed Jul 9, 1:11 am)
Re: [PATCH 3/3] Add timeout feature, Theodore Tso, (Wed Jul 9, 4:09 am)
Re: [PATCH 3/3] Add timeout feature, Dave Chinner, (Wed Jul 9, 4:15 am)
Re: [PATCH 3/3] Add timeout feature, Dave Chinner, (Wed Jul 9, 4:49 am)
Re: [PATCH 3/3] Add timeout feature, Theodore Tso, (Wed Jul 9, 5:24 am)
Re: [PATCH 3/3] Add timeout feature, Olaf , (Wed Jul 9, 5:59 am)
Re: [PATCH 3/3] Add timeout feature, Arjan van de Ven, (Wed Jul 9, 6:53 am)
Re: [PATCH 3/3] Add timeout feature, Arjan van de Ven, (Wed Jul 9, 6:55 am)
Re: [PATCH 3/3] Add timeout feature, Arjan van de Ven, (Wed Jul 9, 6:57 am)
Re: [PATCH 3/3] Add timeout feature, jim owens, (Wed Jul 9, 6:58 am)
Re: [PATCH 3/3] Add timeout feature, jim owens, (Wed Jul 9, 7:13 am)
Re: [PATCH 3/3] Add timeout feature, Pavel Machek, (Wed Jul 9, 1:44 pm)
Re: [PATCH 3/3] Add timeout feature, Pavel Machek, (Wed Jul 9, 1:48 pm)
Re: [PATCH 3/3] Add timeout feature, Pavel Machek, (Sun Jul 13, 5:06 am)
Re: [PATCH 3/3] Add timeout feature, jim owens, (Sun Jul 13, 10:15 am)