On Thu, 17 Jul 2008 16:35:39 +1000 Benjamin Herrenschmidt <email@example.com> wrote:
I think it's good to do so.
It tends to happen. People often don't notice unless it a) crashes or
b) spits warnings or c) screws up my tree or d) all the above plus
Please add a comment which explains what this is.
Please also add a comment telling the world in which header file the
architecture *must* define this macro and then ensure that that header is
included into this file by reliable means. asm/elf.h looks OK.
From my reading, this change will result in no additional code
generation on non-powerpc architectures. This is good. If poss, could
you please verify that theory and perhaps drop a note in the changelog
Apart from that - acked-by-me