[PATCH] AMD IOMMU: replace to_pages macro with iommu_num_pages

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Joerg Roedel
Date: Friday, July 25, 2008 - 5:57 am

This patch removes the to_pages macro from AMD IOMMU code and calls the generic
iommu_num_pages function instead.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/amd_iommu.c |   13 +++++--------
 1 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 7469740..22d7d05 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -29,9 +29,6 @@
 
 #define CMD_SET_TYPE(cmd, t) ((cmd)->data[1] |= ((t) << 28))
 
-#define to_pages(addr, size) \
-	 (round_up(((addr) & ~PAGE_MASK) + (size), PAGE_SIZE) >> PAGE_SHIFT)
-
 #define EXIT_LOOP_COUNT 10000000
 
 static DEFINE_RWLOCK(amd_iommu_devtable_lock);
@@ -185,7 +182,7 @@ static int iommu_flush_pages(struct amd_iommu *iommu, u16 domid,
 		u64 address, size_t size)
 {
 	int s = 0;
-	unsigned pages = to_pages(address, size);
+	unsigned pages = iommu_num_pages(address, size);
 
 	address &= PAGE_MASK;
 
@@ -557,8 +554,8 @@ static struct dma_ops_domain *dma_ops_domain_alloc(struct amd_iommu *iommu,
 	if (iommu->exclusion_start &&
 	    iommu->exclusion_start < dma_dom->aperture_size) {
 		unsigned long startpage = iommu->exclusion_start >> PAGE_SHIFT;
-		int pages = to_pages(iommu->exclusion_start,
-				iommu->exclusion_length);
+		int pages = iommu_num_pages(iommu->exclusion_start,
+					    iommu->exclusion_length);
 		dma_ops_reserve_addresses(dma_dom, startpage, pages);
 	}
 
@@ -767,7 +764,7 @@ static dma_addr_t __map_single(struct device *dev,
 	unsigned int pages;
 	int i;
 
-	pages = to_pages(paddr, size);
+	pages = iommu_num_pages(paddr, size);
 	paddr &= PAGE_MASK;
 
 	address = dma_ops_alloc_addresses(dev, dma_dom, pages);
@@ -802,7 +799,7 @@ static void __unmap_single(struct amd_iommu *iommu,
 	if ((dma_addr == 0) || (dma_addr + size > dma_dom->aperture_size))
 		return;
 
-	pages = to_pages(dma_addr, size);
+	pages = iommu_num_pages(dma_addr, size);
 	dma_addr &= PAGE_MASK;
 	start = dma_addr;
 
-- 
1.5.3.7


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] add iommu_num_pages helper function, Joerg Roedel, (Fri Jul 25, 5:57 am)
[PATCH] AMD IOMMU: replace to_pages macro with iommu_num_pages, Joerg Roedel, (Fri Jul 25, 5:57 am)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Fri Jul 25, 6:15 am)
Re: [PATCH] add iommu_num_pages helper function, Joerg Roedel, (Fri Jul 25, 6:21 am)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Fri Jul 25, 6:34 am)
Re: [PATCH] add iommu_num_pages helper function, Joerg Roedel, (Fri Jul 25, 6:41 am)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Fri Jul 25, 6:57 am)
Re: [PATCH] add iommu_num_pages helper function, Joerg Roedel, (Fri Jul 25, 7:14 am)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Fri Jul 25, 7:32 am)
Re: [PATCH] add iommu_num_pages helper function, Ingo Molnar, (Sat Jul 26, 6:41 am)
Re: [PATCH] add iommu_num_pages helper function, Stephen Rothwell, (Mon Jul 28, 6:07 pm)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Mon Jul 28, 6:46 pm)
Re: [PATCH] add iommu_num_pages helper function, Stephen Rothwell, (Mon Jul 28, 8:56 pm)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Mon Jul 28, 9:38 pm)
Re: [PATCH] add iommu_num_pages helper function, David Miller, (Mon Jul 28, 10:24 pm)
Re: [PATCH] add iommu_num_pages helper function, David Miller, (Mon Jul 28, 10:26 pm)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Mon Jul 28, 10:42 pm)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Mon Jul 28, 10:42 pm)
Re: [PATCH] add iommu_num_pages helper function, Stephen Rothwell, (Mon Jul 28, 11:45 pm)
Re: [PATCH] add iommu_num_pages helper function, Joerg Roedel, (Tue Jul 29, 2:50 am)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Tue Jul 29, 2:58 am)
Re: [PATCH] add iommu_num_pages helper function, Joerg Roedel, (Tue Jul 29, 3:02 am)
Re: [PATCH] add iommu_num_pages helper function, David Miller, (Tue Jul 29, 3:10 am)
Re: [PATCH] add iommu_num_pages helper function, Joerg Roedel, (Tue Jul 29, 3:26 am)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Tue Jul 29, 3:27 am)
Re: [PATCH] add iommu_num_pages helper function, Ingo Molnar, (Tue Jul 29, 3:31 am)
Re: [PATCH] add iommu_num_pages helper function, David Miller, (Tue Jul 29, 3:33 am)
Re: [PATCH] add iommu_num_pages helper function, Ingo Molnar, (Tue Jul 29, 4:27 am)
Re: [PATCH] add iommu_num_pages helper function, Stephen Rothwell, (Tue Jul 29, 5:45 am)
Re: [PATCH] add iommu_num_pages helper function, Jesse Barnes, (Tue Jul 29, 8:45 am)
Re: [PATCH] add iommu_num_pages helper function, Joerg Roedel, (Wed Jul 30, 5:18 am)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Wed Jul 30, 6:16 am)
Re: [PATCH] add iommu_num_pages helper function, Joerg Roedel, (Wed Jul 30, 7:03 am)
Re: [PATCH] add iommu_num_pages helper function, Joerg Roedel, (Wed Jul 30, 11:52 am)
Re: [PATCH] add iommu_num_pages helper function, Benjamin Herrenschmidt, (Wed Jul 30, 3:44 pm)
Re: [PATCH] add iommu_num_pages helper function, Benjamin Herrenschmidt, (Wed Jul 30, 3:44 pm)
Re: [PATCH] add iommu_num_pages helper function, FUJITA Tomonori, (Wed Jul 30, 7:07 pm)