[PATCH 4/9] x86: apic - unify disable_local_APIC

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Cyrill Gorcunov
Date: Sunday, August 17, 2008 - 12:41 pm

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
 arch/x86/kernel/apic_32.c |    9 ++++++---
 arch/x86/kernel/apic_64.c |   14 +++++++++++++-
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c
index 13c4b79..d4efe86 100644
--- a/arch/x86/kernel/apic_32.c
+++ b/arch/x86/kernel/apic_32.c
@@ -838,10 +838,13 @@ void lapic_shutdown(void)
 
 	local_irq_save(flags);
 
-	if (enabled_via_apicbase)
-		disable_local_APIC();
-	else
+#ifdef CONFIG_X86_32
+	if (!enabled_via_apicbase)
 		clear_local_APIC();
+	else
+#endif
+		disable_local_APIC();
+
 
 	local_irq_restore(flags);
 }
diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
index 35e0e2e..cbca413 100644
--- a/arch/x86/kernel/apic_64.c
+++ b/arch/x86/kernel/apic_64.c
@@ -707,6 +707,12 @@ void disable_local_APIC(void)
 #endif
 }
 
+/*
+ * If Linux enabled the LAPIC against the BIOS default disable it down before
+ * re-entering the BIOS on shutdown.  Otherwise the BIOS may get confused and
+ * not power-off.  Additionally clear all LVT entries before disable_local_APIC
+ * for the case where Linux didn't enable the LAPIC.
+ */
 void lapic_shutdown(void)
 {
 	unsigned long flags;
@@ -716,7 +722,13 @@ void lapic_shutdown(void)
 
 	local_irq_save(flags);
 
-	disable_local_APIC();
+#ifdef CONFIG_X86_32
+	if (!enabled_via_apicbase)
+		clear_local_APIC();
+	else
+#endif
+		disable_local_APIC();
+
 
 	local_irq_restore(flags);
 }
-- 
1.6.0.rc1.34.g0fe8c

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/9] -tip/apic merging one more series, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
[PATCH 1/9] x86: apic - rearrange maxcpu definition, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
[PATCH 2/9] x86: apic - unify setup_boot_APIC_clock, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
[PATCH 3/9] x86: apic - unify disable_local_APIC, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
[PATCH 4/9] x86: apic - unify disable_local_APIC, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
[PATCH 5/9] x86: apic - unify connect_bsp_APIC, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
[PATCH 6/9] x86: apic - unify lapic_setup_esr, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
[PATCH 7/9] x86: apic - unify __setup_APIC_LVTT, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
[PATCH 8/9] x86: apic - unify disconnect_bsp_APIC, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
[PATCH 9/9] x86: apic - generic_processor_info, Cyrill Gorcunov, (Sun Aug 17, 12:41 pm)
Re: [PATCH 0/9] -tip/apic merging one more series, Yinghai Lu, (Sun Aug 17, 2:53 pm)
Re: [PATCH 0/9] -tip/apic merging one more series, Cyrill Gorcunov, (Sun Aug 17, 9:22 pm)
Re: [PATCH 0/9] -tip/apic merging one more series, Ingo Molnar, (Mon Aug 18, 12:18 am)
Re: [PATCH 0/9] -tip/apic merging one more series, Ingo Molnar, (Mon Aug 18, 12:24 am)
Re: [PATCH 0/9] -tip/apic merging one more series, Cyrill Gorcunov, (Mon Aug 18, 12:41 am)