Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant expressions | KernelTrap

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant expressions

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: adobriyan

Subject: Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant expressions

Date: Wednesday, August 20, 2008 - 5:39 am

On Wed, Aug 20, 2008 at 03:31:53PM +0300, Boaz Harrosh wrote:
quoted text> Ingo Molnar wrote:
> > * Boaz Harrosh <bharrosh@panasas.com> wrote:
> > 
> >> If the user of virtio_has_feature() must pass a compile-time constant 
> >> then it must be converted to a MACRO, and then the BUILD_BUG_ON will 
> >> work. Or it should be changed to a BUG_ON() if fbit is a runtime 
> >> variable.
> > 
> 
> The use of __builtin_constant_p in inline functions is broken. This
> is because it will give different results depending on the -O level
> used. So I think that using it in the Kernel with inlines is plain
> broken. And should be discouraged.

See how kmalloc() works.

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] BUILD_BUG_ON sucks, Alexey Dobriyan, (Sat Aug 16, 3:09 am)

Re: [PATCH] BUILD_BUG_ON sucks, Rusty Russell, (Sat Aug 16, 3:55 am)

Re: [PATCH] BUILD_BUG_ON sucks, Andrew Morton, (Sat Aug 16, 10:46 am)

Re: [PATCH] BUILD_BUG_ON sucks, Linus Torvalds, (Sat Aug 16, 1:07 pm)

[PATCH] debug: fix BUILD_BUG_ON() for non-constant expressions, Ingo Molnar, (Sun Aug 17, 3:32 am)

Re: [PATCH] BUILD_BUG_ON sucks, Theodore Tso, (Sun Aug 17, 5:19 am)

Re: [PATCH] BUILD_BUG_ON sucks, Andrew Morton, (Sun Aug 17, 9:33 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Linus Torvalds, (Sun Aug 17, 9:56 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Ingo Molnar, (Sun Aug 17, 10:33 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Ingo Molnar, (Sun Aug 17, 10:53 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Linus Torvalds, (Sun Aug 17, 11:39 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Ingo Molnar, (Sun Aug 17, 11:45 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Rusty Russell, (Sun Aug 17, 6:09 pm)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Ingo Molnar, (Mon Aug 18, 12:54 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Boaz Harrosh, (Mon Aug 18, 2:55 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Boaz Harrosh, (Mon Aug 18, 5:32 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Ingo Molnar, (Tue Aug 19, 6:34 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Boaz Harrosh, (Tue Aug 19, 9:33 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Ingo Molnar, (Wed Aug 20, 3:59 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Boaz Harrosh, (Wed Aug 20, 5:31 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., adobriyan, (Wed Aug 20, 5:39 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Boaz Harrosh, (Wed Aug 20, 6:07 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Boaz Harrosh, (Wed Aug 20, 6:21 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Ingo Molnar, (Thu Aug 21, 5:17 am)

Re: [PATCH] debug: fix BUILD_BUG_ON() for non-constant exp ..., Rusty Russell, (Sun Aug 24, 6:19 pm)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List	ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List	ixgbe: fix several counter register errata
Linux Kernel Mailing List	b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List	9p: block-based virtio client
linux-netdev:
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer	Re: [PATCH] af_packet: Don't use s