Re: Linux 2.6.27-rc5: System boot regression caused by commit a2bd7274b47124d2fc4dfdb8c0591f545ba749dd

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Yinghai Lu
Date: Sunday, August 31, 2008 - 2:03 pm

On Sun, Aug 31, 2008 at 11:03 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:

how about


diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index cce2f4c..3b5269a 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -240,6 +240,11 @@ static int __pci_read_base(struct pci_dev *dev,
enum pci_bar_type type,
        pci_read_config_dword(dev, pos, &l);
        pci_write_config_dword(dev, pos, mask);
        pci_read_config_dword(dev, pos, &sz);
+
+       /* sticky and non changable */
+       if (sz == l)
+               goto fail;
+
        pci_write_config_dword(dev, pos, l);

        /*


Rafael,

can you check attach one  to see if we still have warning ?

YH
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.27-rc5, Linus Torvalds, (Thu Aug 28, 4:26 pm)
cpu time oddity (was Re: Linux 2.6.27-rc5), Alistair John Strachan, (Fri Aug 29, 8:42 am)
Re: cpu time oddity (was Re: Linux 2.6.27-rc5), Alistair John Strachan, (Fri Aug 29, 8:56 am)
Re: Linux 2.6.27-rc5, Rafael J. Wysocki, (Fri Aug 29, 10:13 am)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Fri Aug 29, 12:57 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Fri Aug 29, 3:30 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Fri Aug 29, 3:31 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Fri Aug 29, 3:32 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Fri Aug 29, 3:47 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Sat Aug 30, 6:32 am)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Sat Aug 30, 10:14 am)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Sat Aug 30, 12:20 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Sat Aug 30, 12:29 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Sat Aug 30, 12:51 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Sat Aug 30, 1:46 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Sat Aug 30, 2:34 pm)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Rafael J. Wysocki, (Sun Aug 31, 5:27 am)
Re: Linux 2.6.27-rc5: System boot regression caused by com ..., Yinghai Lu, (Sun Aug 31, 2:03 pm)
Re: Linux 2.6.27-rc5, J.A. , (Sun Aug 31, 4:27 pm)