Re: [PATCH] e100: Use pci_pme_active for clearing wake-up events and disabling PME#

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Frans Pop

Subject: Re: [PATCH] e100: Use pci_pme_active for clearing wake-up events and disabling PME#

Date: Tuesday, September 9, 2008 - 9:01 am

On Tuesday 09 September 2008, Rafael J. Wysocki wrote:
quoted text> The appended patch should fix the problem (ISTR sending it some time
> ago already).

Patch works for me.

Thanks Rafael!

quoted text> e100: Use pci_pme_active for clearing wake-up events and disabling PME#
>
> Currently e100 uses pci_enable_wake() to clear pending wake-up events
> and disable PME# during intitialization, but that function is not
> suitable for this purpose, because it immediately returns error code
> if device_may_wakeup() returns false for given device.
>
> Make e100 use pci_pme_active(), which carries out exactly the
> required operations, instead.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

Tested-by: Frans Pop <elendil@planet.nl>
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[regression] e100: PCI wake-up handling rework causes "Err ..., Frans Pop, (Mon Sep 8, 11:12 pm)

[PATCH] e100: Use pci_pme_active for clearing wake-up even ..., Rafael J. Wysocki, (Tue Sep 9, 6:14 am)

Re: [PATCH] e100: Use pci_pme_active for clearing wake-up ..., Frans Pop, (Tue Sep 9, 9:01 am)

Re: [PATCH] e100: Use pci_pme_active for clearing wake-up ..., Andrew Morton, (Wed Sep 10, 3:31 pm)

Re: [PATCH] e100: Use pci_pme_active for clearing wake-up ..., Rafael J. Wysocki, (Wed Sep 10, 4:07 pm)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List	ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List	ixgbe: fix several counter register errata
Linux Kernel Mailing List	b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List	9p: block-based virtio client
linux-netdev:
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney	[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.
Wolfgang Grandegger	[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc < 8 in start_xmi...
Amit Kumar Salecha	[PATCHv3 NEXT 2/2] NET: Add Qlogic ethernet driver for CNA devices
openbsd-misc:
Theo de Raadt	Re: Old IPSEC bug
Tomáš Bodžár	Problem with vpnc connection - check group password !
Insan Praja SW	Mandoc Compiling Error
Carl Roberso	Re: Cannot change MTU of carp interface?
Richard Daemon	Re: booting openbsd on eee without cd-rom

Colocation donated by:

Syndicate