[PATCH] x86: do not expose CONFIG_BSWAP to userspace

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Harvey Harrison
Date: Wednesday, January 28, 2009 - 2:58 pm

Use ifdef __i486__ to ensure the BSWAP instruction is available
on 32-bit x86.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
HPA,

I'm afraid my knowledge of gcc compiler flags for various models is
lacking, I used i486 as suggested, just wanted to make sure I understood
you corectly.

 arch/x86/include/asm/swab.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/swab.h b/arch/x86/include/asm/swab.h
index 306d417..9af180c 100644
--- a/arch/x86/include/asm/swab.h
+++ b/arch/x86/include/asm/swab.h
@@ -7,7 +7,7 @@
 static inline __attribute_const__ __u32 __arch_swab32(__u32 val)
 {
 #ifdef __i386__
-# ifdef CONFIG_X86_BSWAP
+# ifdef __i486__
 	asm("bswap %0" : "=r" (val) : "0" (val));
 # else
 	asm("xchgb %b0,%h0\n\t"	/* swap lower bytes	*/
@@ -37,7 +37,7 @@ static inline __attribute_const__ __u64 __arch_swab64(__u64 val)
 		__u64 u;
 	} v;
 	v.u = val;
-# ifdef CONFIG_X86_BSWAP
+# ifdef __i486__
 	asm("bswapl %0 ; bswapl %1 ; xchgl %0,%1"
 	    : "=r" (v.s.a), "=r" (v.s.b)
 	    : "0" (v.s.a), "1" (v.s.b));
-- 
1.6.1.401.gf39d5



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [mingo@elte.hu: [git pull] headers_check fixes], Linus Torvalds, (Tue Jan 27, 3:57 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], H. Peter Anvin, (Tue Jan 27, 4:22 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Linus Torvalds, (Tue Jan 27, 4:29 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Ingo Molnar, (Tue Jan 27, 4:31 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Linus Torvalds, (Tue Jan 27, 4:43 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Vegard Nossum, (Tue Jan 27, 4:51 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Harvey Harrison, (Tue Jan 27, 5:03 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], H. Peter Anvin, (Tue Jan 27, 5:12 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Linus Torvalds, (Tue Jan 27, 5:19 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], H. Peter Anvin, (Tue Jan 27, 6:02 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Jaswinder Singh Rajput, (Tue Jan 27, 6:36 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Arnd Bergmann, (Wed Jan 28, 5:37 am)
Re: [mingo@elte.hu: [git pull] headers_check fixes], H. Peter Anvin, (Wed Jan 28, 10:48 am)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Harvey Harrison, (Wed Jan 28, 12:22 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Linus Torvalds, (Wed Jan 28, 12:44 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Harvey Harrison, (Wed Jan 28, 1:03 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Sam Ravnborg, (Wed Jan 28, 1:49 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Sam Ravnborg, (Wed Jan 28, 2:06 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], H. Peter Anvin, (Wed Jan 28, 2:23 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], H. Peter Anvin, (Wed Jan 28, 2:25 pm)
[PATCH] x86: do not expose CONFIG_BSWAP to userspace, Harvey Harrison, (Wed Jan 28, 2:58 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, Linus Torvalds, (Wed Jan 28, 3:13 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, H. Peter Anvin, (Wed Jan 28, 3:15 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, Harvey Harrison, (Wed Jan 28, 3:38 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, Harvey Harrison, (Wed Jan 28, 3:40 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, Arnd Bergmann, (Wed Jan 28, 4:24 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, H. Peter Anvin, (Wed Jan 28, 4:27 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, H. Peter Anvin, (Wed Jan 28, 4:30 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, Harvey Harrison, (Wed Jan 28, 4:36 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, H. Peter Anvin, (Wed Jan 28, 4:47 pm)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Jaswinder Singh Rajput, (Fri Jan 30, 7:01 am)
Re: [mingo@elte.hu: [git pull] headers_check fixes], Ingo Molnar, (Fri Jan 30, 11:20 am)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, H. Peter Anvin, (Fri Jan 30, 11:20 am)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, Maciej W. Rozycki, (Sat Jan 31, 11:43 am)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, H. Peter Anvin, (Sat Jan 31, 1:24 pm)
Re: [PATCH] x86: do not expose CONFIG_BSWAP to userspace, Arnd Bergmann, (Tue Feb 3, 11:19 am)