Re: Reworking suspend-resume sequence (was: Re: PCI PM: Restore standard config registers of all devices early)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Tuesday, February 3, 2009 - 11:31 am

On Tue, 3 Feb 2009, Linus Torvalds wrote:

Btw, this is very much the case for MSI irq's in particular. If you ask to 
_mask_ them, it will go to the look up the device list and try to mask 
them (quite frankly, that sounds insane to me, but whatever), but that not 
what the irq layer does for the simple "disable()" case.

It will literally just set the flag, and then even if an interrupt happens 
afterwards, it will just ->ack it, and then call the ->end thing - and 
doesn't need to do anything else in the whole "disable" path because MSI's 
are obviously edge-triggered.

And the ACK is a pure (x2/io)apic thing, and again doesn't actually touch 
the device itself, only the irq controller itself.

So while it is possible in theory that some irq controller ends up trying 
to access the device for disable_irq, I don't think it's ever true in 
reality.

But it's possible that I overlooked some really odd case, of course.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 2:54 am)
Re: PCI PM: Restore standard config registers of all devic ..., Rafael J. Wysocki, (Mon Feb 2, 10:20 am)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 1:29 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 1:33 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 2:00 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 2:07 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 2:19 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 3:28 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 3:48 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 3:57 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 5:11 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 5:23 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 5:58 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 6:03 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 6:12 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 6:32 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 6:46 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 8:30 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 8:51 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 8:55 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 9:03 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 9:21 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Mon Feb 2, 11:07 pm)
Reworking suspend-resume sequence (was: Re: PCI PM: Restor ..., Rafael J. Wysocki, (Tue Feb 3, 10:04 am)
Re: Reworking suspend-resume sequence (was: Re: PCI PM: Re ..., Linus Torvalds, (Tue Feb 3, 11:31 am)
Re: Reworking suspend-resume sequence (was: Re: PCI PM: Re ..., Benjamin Herrenschmidt, (Tue Feb 3, 2:02 pm)
Re: Reworking suspend-resume sequence (was: Re: PCI PM: Re ..., Benjamin Herrenschmidt, (Tue Feb 3, 2:11 pm)
Re: Reworking suspend-resume sequence (was: Re: PCI PM: Re ..., Benjamin Herrenschmidt, (Tue Feb 3, 3:33 pm)
Re: PCI PM: Restore standard config registers of all devic ..., Benjamin Herrenschmidt, (Tue Feb 3, 3:59 pm)
Re: Reworking suspend-resume sequence (was: Re: PCI PM: Re ..., Benjamin Herrenschmidt, (Tue Feb 3, 4:05 pm)
Re: Reworking suspend-resume sequence (was: Re: PCI PM: Re ..., Benjamin Herrenschmidt, (Tue Feb 3, 5:27 pm)
Re: Reworking suspend-resume sequence (was: Re: PCI PM: Re ..., Benjamin Herrenschmidt, (Wed Mar 4, 4:25 pm)
Re: Reworking suspend-resume sequence (was: Re: PCI PM: Re ..., Rafael J. Wysocki, (Thu Mar 5, 12:09 pm)