On Wed, Jan 6, 2010 at 17:40, Jason Wessel wrote:
quoted text
> Mike Frysinger wrote:
>> On Wed, Jan 6, 2010 at 15:34, Jason Wessel wrote:
>>> Mike Frysinger wrote:
>>>> also, i see you added "notrace" to the Blackfin probe_kernel_write ...
>>>> was that intentional ?  if so, this should probably go into
>>>> include/linux/uaccess.h instead
>>>>
>>> The notrace was just a cut and paste of the original in mm/maccess.c
>>
>> ah, i thought i checked mm/maccess.c, but i guess i looked at just
>> probe_kernel_read().  the fact that this was missed under the Blackfin
>> code is a good example for why notrace should be on prototypes, not
>> function definitions :).  i'll send a sep patch for just this.
>
> Thanks for the input.  I made the changes you talked about and tested
> the compilation on all the kgdb regression compiles.
>
> I split the patch into 2 parts, 1 for the generic change, and 1 for the
> blackfin cleanup.  Let me know if you approve and I can add acks from
> you as well.

i'd drop the notrace from the Blackfin probe_kernel_write and the
common __probe_kernel_write ... but otherwise, looks good.  thanks
again.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
-mike
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/