Re: [PATCH] checkpatch: allow single space before labels | KernelTrap

Re: [PATCH] checkpatch: allow single space before labels

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Mike Frysinger

Subject: Re: [PATCH] checkpatch: allow single space before labels

Date: Monday, October 18, 2010 - 11:21 am

On Mon, Oct 18, 2010 at 10:58, Peter Zijlstra wrote:
quoted text> On Mon, 2010-10-18 at 10:54 -0400, Ted Ts'o wrote:
>> Note that there is absolutely nothing about how labels should be
>> indented in CodingStyle at all, and I very much resist code
>> straightjackets being imposed by checkpatch.pl implementors.
>>
>> Can we please stop this nonsense?
>
> 1) ignoring checkpatch over taste is good
> 2) by 1) its impossible to get checkpatch right
> 3) therefore pure checkpatch patches are nonsense

sounds like an ACK for Joe's patch

Joe: could you post an updated patch ?
-mke
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] checkpatch: allow single space before labels, Mike Frysinger, (Sun Oct 17, 1:05 am)

Re: [PATCH] checkpatch: allow single space before labels, Joe Perches, (Sun Oct 17, 1:21 am)

Re: [PATCH] checkpatch: allow single space before labels, Mike Frysinger, (Sun Oct 17, 1:24 am)

Re: [PATCH] checkpatch: allow single space before labels, Peter Zijlstra, (Sun Oct 17, 3:20 am)

Re: [PATCH] checkpatch: allow single space before labels, Peter Zijlstra, (Sun Oct 17, 3:21 am)

Re: [PATCH] checkpatch: allow single space before labels, Mike Frysinger, (Sun Oct 17, 3:30 am)

Re: [PATCH] checkpatch: allow single space before labels, Peter Zijlstra, (Sun Oct 17, 3:37 am)

Re: [PATCH] checkpatch: allow single space before labels, Mike Frysinger, (Sun Oct 17, 3:52 am)

Re: [PATCH] checkpatch: allow single space before labels, Joe Perches, (Sun Oct 17, 9:54 am)

Re: [PATCH] checkpatch: allow single space before labels, Peter Zijlstra, (Sun Oct 17, 12:30 pm)

Re: [PATCH] checkpatch: allow single space before labels, Joe Perches, (Sun Oct 17, 12:38 pm)

Re: [PATCH] checkpatch: allow single space before labels, Mike Frysinger, (Sun Oct 17, 12:49 pm)

Re: [PATCH] checkpatch: allow single space before labels, Peter Zijlstra, (Sun Oct 17, 12:49 pm)

Re: [PATCH] checkpatch: allow single space before labels, Peter Zijlstra, (Sun Oct 17, 1:01 pm)

Re: [PATCH] checkpatch: allow single space before labels, Mike Frysinger, (Sun Oct 17, 1:26 pm)

Re: [PATCH] checkpatch: allow single space before labels, Ted Ts'o, (Mon Oct 18, 7:39 am)

Re: [PATCH] checkpatch: allow single space before labels, Ted Ts'o, (Mon Oct 18, 7:54 am)

Re: [PATCH] checkpatch: allow single space before labels, Peter Zijlstra, (Mon Oct 18, 7:58 am)

Re: [PATCH] checkpatch: allow single space before labels, Peter Zijlstra, (Mon Oct 18, 8:03 am)

Re: [PATCH] checkpatch: allow single space before labels, Mike Frysinger, (Mon Oct 18, 11:21 am)

Re: [PATCH] checkpatch: allow single space before labels, Peter Zijlstra, (Mon Oct 18, 11:32 am)

Re: [PATCH] checkpatch: allow single space before labels, Joe Perches, (Mon Oct 18, 12:09 pm)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List	ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List	ixgbe: fix several counter register errata
Linux Kernel Mailing List	b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List	9p: block-based virtio client
linux-netdev:
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()