login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
October
»
19
Re: [PATCH] tracing: Cleanup the convoluted softirq tracepoints
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Peter Zijlstra
Subject:
Re: [PATCH] tracing: Cleanup the convoluted softirq tracepoints
Date: Tuesday, October 19, 2010 - 6:08 am
On Tue, 2010-10-19 at 15:00 +0200, Thomas Gleixner wrote:
quoted text
> > With the addition of trace_softirq_raise() the softirq tracepoint got > even more convoluted. Why the tracepoints take two pointers to assign > an integer is beyond my comprehension. > > But adding an extra case which treats the first pointer as an unsigned > long when the second pointer is NULL including the back and forth > type casting is just horrible. > > Convert the softirq tracepoints to take a single unsigned int argument > for the softirq vector number and fix the call sites. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl> A much needed cleanup indeed! --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH v4 0/5] netdev: show a process of packets
, Koki Sanagi
, (Mon Aug 23, 2:41 am)
[PATCH v4 1/5] irq: add tracepoint to softirq_raise
, Koki Sanagi
, (Mon Aug 23, 2:42 am)
[PATCH v4 2/5] napi: convert trace_napi_poll to TRACE_EVENT
, Koki Sanagi
, (Mon Aug 23, 2:43 am)
[PATCH v4 4/5] skb: add tracepoints to freeing skb
, Koki Sanagi
, (Mon Aug 23, 2:46 am)
[PATCH v4 5/5] perf:add a script shows a process of packet
, Koki Sanagi
, (Mon Aug 23, 2:47 am)
Re: [PATCH v4 2/5] napi: convert trace_napi_poll to TRACE_ ...
, David Miller
, (Mon Aug 23, 8:52 pm)
Re: [PATCH v4 3/5] netdev: add tracepoints to netdev layer
, David Miller
, (Mon Aug 23, 8:53 pm)
Re: [PATCH v4 4/5] skb: add tracepoints to freeing skb
, David Miller
, (Mon Aug 23, 8:53 pm)
Re: [PATCH v4 5/5] perf:add a script shows a process of packet
, David Miller
, (Mon Aug 23, 8:53 pm)
Re: [PATCH v4 0/5] netdev: show a process of packets
, Steven Rostedt
, (Mon Aug 30, 4:50 pm)
Re: [PATCH v4 0/5] netdev: show a process of packets
, Koki Sanagi
, (Thu Sep 2, 7:10 pm)
Re: [PATCH v4 0/5] netdev: show a process of packets
, David Miller
, (Thu Sep 2, 7:17 pm)
Re: [PATCH v4 0/5] netdev: show a process of packets
, Koki Sanagi
, (Thu Sep 2, 7:55 pm)
Re: [PATCH v4 0/5] netdev: show a process of packets
, Frederic Weisbecker
, (Thu Sep 2, 9:46 pm)
Re: [PATCH v4 0/5] netdev: show a process of packets
, Koki Sanagi
, (Thu Sep 2, 10:12 pm)
Re: [PATCH v4 1/5] irq: add tracepoint to softirq_raise
, Frederic Weisbecker
, (Fri Sep 3, 8:29 am)
Re: [PATCH v4 1/5] irq: add tracepoint to softirq_raise
, Steven Rostedt
, (Fri Sep 3, 8:39 am)
Re: [PATCH v4 1/5] irq: add tracepoint to softirq_raise
, Frederic Weisbecker
, (Fri Sep 3, 8:42 am)
Re: [PATCH v4 1/5] irq: add tracepoint to softirq_raise
, Steven Rostedt
, (Fri Sep 3, 8:43 am)
Re: [PATCH v4 1/5] irq: add tracepoint to softirq_raise
, Frederic Weisbecker
, (Fri Sep 3, 8:50 am)
Re: [PATCH v4 1/5] irq: add tracepoint to softirq_raise
, Koki Sanagi
, (Sun Sep 5, 6:46 pm)
Re: [PATCH v4 5/5] perf:add a script shows a process of packet
, Frederic Weisbecker
, (Tue Sep 7, 9:57 am)
[tip:perf/core] irq: Add tracepoint to softirq_raise
, tip-bot for Lai Jian ...
, (Wed Sep 8, 1:33 am)
[tip:perf/core] napi: Convert trace_napi_poll to TRACE_EVENT
, tip-bot for Neil Horman
, (Wed Sep 8, 1:34 am)
[tip:perf/core] skb: Add tracepoints to freeing skb
, tip-bot for Koki Sanagi
, (Wed Sep 8, 1:35 am)
[tip:perf/core] perf: Add a script to show packets processing
, tip-bot for Koki Sanagi
, (Wed Sep 8, 1:35 am)
[sparc build bug] Re: [tip:perf/core] irq: Add tracepoint ...
, Ingo Molnar
, (Wed Sep 8, 4:25 am)
[PATCH] irq: Fix circular headers dependency
, Frederic Weisbecker
, (Wed Sep 8, 5:26 am)
[tip:perf/core] irq: Fix circular headers dependency
, tip-bot for Frederic ...
, (Thu Sep 9, 12:54 pm)
Re: [sparc build bug] Re: [tip:perf/core] irq: Add tracepo ...
, Peter Zijlstra
, (Mon Oct 18, 2:44 am)
Re: [sparc build bug] Re: [tip:perf/core] irq: Add tracepo ...
, Peter Zijlstra
, (Mon Oct 18, 3:11 am)
Re: [sparc build bug] Re: [tip:perf/core] irq: Add tracepo ...
, Heiko Carstens
, (Mon Oct 18, 3:26 am)
Re: [sparc build bug] Re: [tip:perf/core] irq: Add tracepo ...
, Peter Zijlstra
, (Mon Oct 18, 3:48 am)
Re: [sparc build bug] Re: [tip:perf/core] irq: Add tracepo ...
, Koki Sanagi
, (Tue Oct 19, 3:58 am)
Re: [sparc build bug] Re: [tip:perf/core] irq: Add tracepo ...
, Peter Zijlstra
, (Tue Oct 19, 4:25 am)
[PATCH] tracing: Cleanup the convoluted softirq tracepoints
, Thomas Gleixner
, (Tue Oct 19, 6:00 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Peter Zijlstra
, (Tue Oct 19, 6:08 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Mathieu Desnoyers
, (Tue Oct 19, 6:22 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Tue Oct 19, 6:41 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 6:54 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Mathieu Desnoyers
, (Tue Oct 19, 7:00 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Tue Oct 19, 7:07 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Mathieu Desnoyers
, (Tue Oct 19, 7:28 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 7:46 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Tue Oct 19, 12:49 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 1:55 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Tue Oct 19, 2:07 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, David Daney
, (Tue Oct 19, 2:16 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 2:23 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Jason Baron
, (Tue Oct 19, 2:28 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Jason Baron
, (Tue Oct 19, 2:32 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, David Daney
, (Tue Oct 19, 2:38 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Tue Oct 19, 2:45 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 2:47 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Tue Oct 19, 2:48 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Tue Oct 19, 2:55 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Tue Oct 19, 3:04 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 3:14 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Tue Oct 19, 3:17 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 3:23 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Tue Oct 19, 3:26 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Peter Zijlstra
, (Tue Oct 19, 3:27 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 3:33 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Jason Baron
, (Tue Oct 19, 3:38 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Mathieu Desnoyers
, (Tue Oct 19, 3:41 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Tue Oct 19, 3:44 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Tue Oct 19, 3:49 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 3:56 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Tue Oct 19, 3:57 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 4:05 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Tue Oct 19, 4:09 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Tue Oct 19, 4:39 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 4:45 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Jason Baron
, (Tue Oct 19, 5:43 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Tue Oct 19, 6:36 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Jason Baron
, (Tue Oct 19, 6:52 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Jason Baron
, (Wed Oct 20, 8:27 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Mathieu Desnoyers
, (Wed Oct 20, 8:41 am)
[tip:perf/core] tracing: Cleanup the convoluted softirq tr ...
, tip-bot for Thomas G ...
, (Thu Oct 21, 7:52 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Thu Oct 21, 9:18 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Thu Oct 21, 10:05 am)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Thomas Gleixner
, (Thu Oct 21, 12:56 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Mon Oct 25, 2:54 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Mathieu Desnoyers
, (Mon Oct 25, 3:01 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Mon Oct 25, 3:12 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Mon Oct 25, 3:19 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Mon Oct 25, 3:31 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, H. Peter Anvin
, (Mon Oct 25, 3:32 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Mathieu Desnoyers
, (Mon Oct 25, 3:55 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Steven Rostedt
, (Mon Oct 25, 5:39 pm)
Re: [PATCH] tracing: Cleanup the convoluted softirq tracep ...
, Mathieu Desnoyers
, (Mon Oct 25, 6:14 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Og dreams of kernels
Jens Axboe
[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann
Re: finding your own dead "CONFIG_" variables
Mark Brown
[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds
[LGUEST] Look in object dir for .config
git
:
Brian Downing
Re: Git in a Nutshell guide
John Benes
Re: master has some toys
Matthias Lederhofer
[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian
[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano
Re: Rss produced by git is not valid xml?
git-commits-head
:
Linux Kernel Mailing List
iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List
ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List
ixgbe: fix several counter register errata
Linux Kernel Mailing List
b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List
9p: block-based virtio client
linux-netdev
:
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney
[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.
Wolfgang Grandegger
[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc < 8 in start_xmi...
Amit Kumar Salecha
[PATCHv3 NEXT 2/2] NET: Add Qlogic ethernet driver for CNA devices
openbsd-misc
:
Theo de Raadt
Re: Old IPSEC bug
Tomáš Bodžár
Problem with vpnc connection - check group password !
Insan Praja SW
Mandoc Compiling Error
Carl Roberso
Re: Cannot change MTU of carp interface?
Richard Daemon
Re: booting openbsd on eee without cd-rom
Colocation donated by:
Syndicate