Home » Mailing list archives » linux-kernel » 2010 » October » 5

RE: [PATCH 0/4] move TI_ST driver out of staging

Previous thread: [Patch] IBM Real-Time "SMI Free" mode driver -v7 by Vernon Mauery on Tuesday, October 5, 2010 - 3:47 pm. (9 messages)

Next thread: Email Notification** by Super Enalotto International** on Saturday, October 2, 2010 - 12:21 pm. (1 message)
[view original message]
From: pavan_savoy
Subject: [PATCH 0/4] move TI_ST driver out of staging
Date: Tuesday, October 5, 2010 - 5:08 pm

From: Pavan Savoy <pavan_savoy@ti.com>

Texas Instrument's WiLink 7 chipset packs wireless technologies like
Bluetooth, FM, GPS and WLAN into a single die.
Among these the Bluetooth, FM Rx/Tx and GPS are interfaced to a apps processor
over a single UART.

This line discipline driver allows various protocol drivers such as Bluetooth
BlueZ driver, FM V4L2 driver and GPS simple character device driver
to communicate with its relevant core in the chip.

The following patches,
1. removes the driver from staging
2. adds the driver to drivers/misc/ directory since it really doesn't
belong anywhere else
3. adds in the Kconfig and Makefile for the driver
4. modifies the drivers/misc/Kconfig and drivers/misc/Makefile for the
driver to be available to be built along with rest of the kernel.

Pavan Savoy (4):
  drivers:staging:ti-st: remove TI_ST from staging
  drivers:misc: ti-st: sources for TI_ST driver
  drivers:misc: ti-st: Kconfig & Makefile for TI_ST
  drivers:misc: modify Kconfig & Makefile for TI_ST

 drivers/misc/Kconfig            |    1 +
 drivers/misc/Makefile           |    1 +
 drivers/misc/ti-st/Kconfig      |   17 +
 drivers/misc/ti-st/Makefile     |    6 +
 drivers/misc/ti-st/st_core.c    | 1031 +++++++++++++++++++++++++++++++++++++++
 drivers/misc/ti-st/st_kim.c     |  798 ++++++++++++++++++++++++++++++
 drivers/misc/ti-st/st_ll.c      |  150 ++++++
 drivers/staging/ti-st/Kconfig   |   11 -
 drivers/staging/ti-st/Makefile  |    2 -
 drivers/staging/ti-st/st_core.c | 1030 --------------------------------------
 drivers/staging/ti-st/st_kim.c  |  797 ------------------------------
 drivers/staging/ti-st/st_ll.c   |  149 ------
 12 files changed, 2004 insertions(+), 1989 deletions(-)
 create mode 100644 drivers/misc/ti-st/Kconfig
 create mode 100644 drivers/misc/ti-st/Makefile
 create mode 100644 drivers/misc/ti-st/st_core.c
 create mode 100644 drivers/misc/ti-st/st_kim.c
 create mode 100644 drivers/misc/ti-st/st_ll.c
 delete mode 100644 ...
[ message continues ]
[view original message]
From: pavan_savoy
Subject: [PATCH 3/4] drivers:misc: ti-st: Kconfig & Makefile for TI_ST
Date: Tuesday, October 5, 2010 - 5:08 pm

From: Pavan Savoy <pavan_savoy@ti.com>

Add the Kconfig and the Makefile for the TI_ST driver.
TI_ST driver is the line discipline driver for the Texas Instrument's
WiLink chipsets.

Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
---
 drivers/misc/ti-st/Kconfig  |   17 +++++++++++++++++
 drivers/misc/ti-st/Makefile |    6 ++++++
 2 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 drivers/misc/ti-st/Kconfig
 create mode 100644 drivers/misc/ti-st/Makefile

diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig
new file mode 100644
index 0000000..2c8c3f3
--- /dev/null
+++ b/drivers/misc/ti-st/Kconfig
@@ -0,0 +1,17 @@
+#
+# TI's shared transport line discipline and the protocol
+# drivers (BT, FM and GPS)
+#
+menu "Texas Instruments shared transport line discipline"
+config TI_ST
+	tristate "Shared transport core driver"
+	depends on RFKILL
+	select FW_LOADER
+	help
+	  This enables the shared transport core driver for TI
+	  BT / FM and GPS combo chips. This enables protocol drivers
+	  to register themselves with core and send data, the responses
+	  are returned to relevant protocol drivers based on their
+	  packet types.
+
+endmenu
diff --git a/drivers/misc/ti-st/Makefile b/drivers/misc/ti-st/Makefile
new file mode 100644
index 0000000..78d7ebb
--- /dev/null
+++ b/drivers/misc/ti-st/Makefile
@@ -0,0 +1,6 @@
+#
+# Makefile for TI's shared transport line discipline
+# and its protocol drivers (BT, FM, GPS)
+#
+obj-$(CONFIG_TI_ST) 		+= st_drv.o
+st_drv-objs			:= st_core.o st_kim.o st_ll.o
-- 
1.6.5

--


[ message continues ]
[view original message]
From: pavan_savoy
Subject: [PATCH 4/4] drivers:misc: modify Kconfig & Makefile for TI_ST
Date: Tuesday, October 5, 2010 - 5:08 pm

From: Pavan Savoy <pavan_savoy@ti.com>

Add the ti-st folder to list of drivers under drivers/misc.

Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
---
 drivers/misc/Kconfig  |    1 +
 drivers/misc/Makefile |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 53b21ff..9d0a84d 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -415,5 +415,6 @@ source "drivers/misc/c2port/Kconfig"
 source "drivers/misc/eeprom/Kconfig"
 source "drivers/misc/cb710/Kconfig"
 source "drivers/misc/iwmc3200top/Kconfig"
+source "drivers/misc/ti-st/Kconfig"
 
 endif # MISC_DEVICES
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 4c771a2..d71d5a7 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -37,3 +37,4 @@ obj-$(CONFIG_VMWARE_BALLOON)	+= vmw_balloon.o
 obj-$(CONFIG_ARM_CHARLCD)	+= arm-charlcd.o
 obj-$(CONFIG_AB8500_PWM)	+= ab8500-pwm.o
 obj-$(CONFIG_PCH_PHUB)		+= pch_phub.o
+obj-y				+= ti-st/
-- 
1.6.5

--


[ message continues ]
[view original message]
From: pavan_savoy
Subject: [PATCH 1/4] drivers:staging:ti-st: remove TI_ST from staging
Date: Tuesday, October 5, 2010 - 5:08 pm

From: Pavan Savoy <pavan_savoy@ti.com>

remove the 3 source files st_core.c, st_kim.c and st_ll.c
from staging, also modify the Kconfig and Makefile to not
to include them in build.

Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
---
 drivers/staging/ti-st/Kconfig   |   11 -
 drivers/staging/ti-st/Makefile  |    2 -
 drivers/staging/ti-st/st_core.c | 1030 ---------------------------------------
 drivers/staging/ti-st/st_kim.c  |  797 ------------------------------
 drivers/staging/ti-st/st_ll.c   |  149 ------
 5 files changed, 0 insertions(+), 1989 deletions(-)
 delete mode 100644 drivers/staging/ti-st/st_core.c
 delete mode 100644 drivers/staging/ti-st/st_kim.c
 delete mode 100644 drivers/staging/ti-st/st_ll.c

diff --git a/drivers/staging/ti-st/Kconfig b/drivers/staging/ti-st/Kconfig
index 858062d..074b8e8 100644
--- a/drivers/staging/ti-st/Kconfig
+++ b/drivers/staging/ti-st/Kconfig
@@ -3,17 +3,6 @@
 # drivers (BT, FM and GPS)
 #
 menu "Texas Instruments shared transport line discipline"
-config TI_ST
-	tristate "Shared transport core driver"
-	depends on RFKILL
-	select FW_LOADER
-	help
-	  This enables the shared transport core driver for TI
-	  BT / FM and GPS combo chips. This enables protocol drivers
-	  to register themselves with core and send data, the responses
-	  are returned to relevant protocol drivers based on their
-	  packet types.
-
 config ST_BT
 	tristate "BlueZ bluetooth driver for ST"
 	depends on BT && RFKILL
diff --git a/drivers/staging/ti-st/Makefile b/drivers/staging/ti-st/Makefile
index 0167d1d..5f11b82 100644
--- a/drivers/staging/ti-st/Makefile
+++ b/drivers/staging/ti-st/Makefile
@@ -2,6 +2,4 @@
 # Makefile for TI's shared transport line discipline
 # and its protocol drivers (BT, FM, GPS)
 #
-obj-$(CONFIG_TI_ST) 		+= st_drv.o
-st_drv-objs			:= st_core.o st_kim.o st_ll.o
 obj-$(CONFIG_ST_BT) 		+= bt_drv.o
diff --git a/drivers/staging/ti-st/st_core.c b/drivers/staging/ti-st/st_core.c
deleted file mode 100644
index ...
[ message continues ]
[view original message]
From: pavan_savoy
Subject: [PATCH 2/4] drivers:misc: ti-st: sources for TI_ST driver
Date: Tuesday, October 5, 2010 - 5:08 pm

From: Pavan Savoy <pavan_savoy@ti.com>

Texas Instrument's WiLink 7 chipset packs wireless technologies like
Bluetooth, FM, GPS and WLAN into a single die.
Among these the Bluetooth, FM Rx/Tx and GPS are interfaced to a apps processor
over a single UART.

This line discipline driver allows various protocol drivers such as Bluetooth
BlueZ driver, FM V4L2 driver and GPS simple character device driver
to communicate with its relevant core in the chip.

Each protocol or technologies use a logical channel to communicate with chip.
Bluetooth uses the HCI-H4 [channels 1-4], FM uses a CH-8 and
GPS a CH-9 protocol. The driver also constitutes the TI HCI-LL Power
Management protocol which use channels 30-33.

Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
---
 drivers/misc/ti-st/st_core.c | 1031 ++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/ti-st/st_kim.c  |  798 ++++++++++++++++++++++++++++++++
 drivers/misc/ti-st/st_ll.c   |  150 ++++++
 3 files changed, 1979 insertions(+), 0 deletions(-)
 create mode 100644 drivers/misc/ti-st/st_core.c
 create mode 100644 drivers/misc/ti-st/st_kim.c
 create mode 100644 drivers/misc/ti-st/st_ll.c

diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
new file mode 100644
index 0000000..9bae0eb
--- /dev/null
+++ b/drivers/misc/ti-st/st_core.c
@@ -0,0 +1,1031 @@
+/*
+ *  Shared Transport Line discipline driver Core
+ *	This hooks up ST KIM driver and ST LL driver
+ *  Copyright (C) 2009-2010 Texas Instruments
+ *  Author: Pavan Savoy <pavan_savoy@ti.com>
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License version 2 as
+ *  published by the Free Software Foundation.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  ...
[ message continues ]
[view original message]
From: Greg KH
Subject: Re: [PATCH 0/4] move TI_ST driver out of staging
Date: Tuesday, October 5, 2010 - 4:22 pm

These two should be together, so we see an obvious "move the files" type

So this really could just be one patch all at once, care to redo?

thanks,

greg k-h
--


[ message continues ]
[view original message]
From: Savoy, Pavan
Subject: RE: [PATCH 0/4] move TI_ST driver out of staging
Date: Tuesday, October 5, 2010 - 4:47 pm

OK. all in 1 it is.
________________________________________
From: Greg KH [greg@kroah.com]
Sent: Wednesday, October 06, 2010 4:52 AM
To: Savoy, Pavan
Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; alan@lxorguk.ukuu.org.uk; devel@driverdev.osuosl.org
Subject: Re: [PATCH 0/4] move TI_ST driver out of staging


These two should be together, so we see an obvious "move the files" type

So this really could just be one patch all at once, care to redo?

thanks,

greg k-h
--


[ message continues ]
Previous thread: [Patch] IBM Real-Time "SMI Free" mode driver -v7 by Vernon Mauery on Tuesday, October 5, 2010 - 3:47 pm. (9 messages)

Next thread: Email Notification** by Super Enalotto International** on Saturday, October 2, 2010 - 12:21 pm. (1 message)