Re: [PATCH 1/6 v6] ARM: Add basic architecture support for VIA/WonderMedia 85xx SoC's

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alexey Charkov
Date: Friday, November 12, 2010 - 1:14 pm

> Russell, could you please elaborate on your comment regarding spinlocks

My fault: actually, those were not all lock debugging functions. It
really prints errors when lock correctness proving is enabled. I thus
decided to just assign the callback functions directly to irq_desc
struct fields, as it is done in mach-msm.

There is, however, another error showing up: it complains about my use
of ioremap inside arch_reset(). Is it fine to just hardcode the
virtual address of the respective register and use that directly in
this case? Something along the lines of:

/* PM Software Reset request register */
#define VT8500_PMSR_VIRT	0xf8130060

static inline void arch_reset(char mode, const char *cmd)
{
	writel(1, VT8500_PMSR_VIRT);
}

Thanks,
Alexey
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 1/6 v2] ARM: Add basic architecture support for ..., Russell King - ARM Linux, (Sun Nov 7, 9:57 am)
Re: [PATCH 1/6 v2] ARM: Add basic architecture support for ..., Russell King - ARM Linux, (Sun Nov 7, 10:00 am)
Re: [PATCH 1/6 v2] ARM: Add basic architecture support for ..., Russell King - ARM Linux, (Sun Nov 7, 10:17 am)
Re: [PATCH 6/6 v4] ARM: Add support for the display contro ..., Guennadi Liakhovetski, (Tue Nov 9, 12:36 am)
Re: [PATCH 6/6 v3] ARM: Add support for the display contro ..., Russell King - ARM Linux, (Tue Nov 9, 3:33 am)
Re: [PATCH 6/6 v3] ARM: Add support for the display contro ..., Russell King - ARM Linux, (Tue Nov 9, 4:04 am)
Re: [PATCH 6/6 v3] ARM: Add support for the display contro ..., Geert Uytterhoeven, (Tue Nov 9, 6:02 am)
Re: [PATCH 1/6 v4] ARM: Add basic architecture support for ..., Russell King - ARM Linux, (Wed Nov 10, 8:18 am)
Re: [PATCH 1/6 v5] ARM: Add basic architecture support for ..., Russell King - ARM Linux, (Thu Nov 11, 4:49 pm)
Re: [PATCH 1/6 v6] ARM: Add basic architecture support for ..., Alexey Charkov, (Fri Nov 12, 1:14 pm)
Re: [PATCH 5/6 v2] rtc: Add support for the RTC in VIA VT8 ..., Lars-Peter Clausen, (Sat Nov 13, 5:14 am)
Re: [PATCH 5/6 v3] rtc: Add support for the RTC in VIA VT8 ..., Lars-Peter Clausen, (Sun Nov 14, 8:50 am)
Re: [PATCH 5/6 v4] rtc: Add support for the RTC in VIA VT8 ..., Lars-Peter Clausen, (Wed Nov 24, 12:23 pm)
Re: [PATCH 1/6 v8] ARM: Add basic architecture support for ..., Russell King - ARM Linux, (Mon Dec 20, 12:15 pm)