Home » Mailing list archives » linux-kernel » 2010 » November » 15

[PATCH 5/6] Btrfs: fail if we try to use hole punch

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Josef Bacik
Subject: [PATCH 5/6] Btrfs: fail if we try to use hole punch
Date: Monday, November 15, 2010 - 10:05 am

Btrfs doesn't have the ability to punch holes yet, so make sure we return
EOPNOTSUPP if we try to use hole punching through fallocate.  This support can
be added later.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
---
 fs/btrfs/inode.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 78877d7..6f08892 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6936,6 +6936,10 @@ static long btrfs_fallocate(struct inode *inode, int mode,
 	alloc_start = offset & ~mask;
 	alloc_end =  (offset + len + mask) & ~mask;
 
+	/* We only support the FALLOC_FL_KEEP_SIZE mode */
+	if (mode && (mode != FALLOC_FL_KEEP_SIZE))
+		return -EOPNOTSUPP;
+
 	/*
 	 * wait for ordered IO before we have any locks.  We'll loop again
 	 * below with the locks held.
-- 
1.6.6.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Hole Punching V2, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 2/6] XFS: handle hole punching via fallocate properly, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 3/6] Ocfs2: handle hole punching via fallocate properly, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 5/6] Btrfs: fail if we try to use hole punch, Josef Bacik, (Mon Nov 15, 10:05 am)
[PATCH 6/6] Gfs2: fail if we try to use hole punch, Josef Bacik, (Mon Nov 15, 10:05 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Jan Kara, (Tue Nov 16, 4:16 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Jan Kara, (Tue Nov 16, 4:43 am)
Re: [PATCH 3/6] Ocfs2: handle hole punching via fallocate ..., Jan Kara, (Tue Nov 16, 4:50 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Jan Kara, (Tue Nov 16, 4:52 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Avi Kivity, (Tue Nov 16, 5:25 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 5:50 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 5:52 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 5:53 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Jan Kara, (Tue Nov 16, 6:14 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 9:05 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Pádraig Brady, (Tue Nov 16, 9:20 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 9:33 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Pádraig Brady, (Tue Nov 16, 9:56 am)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Greg Freemyer, (Tue Nov 16, 1:47 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger, (Tue Nov 16, 5:22 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Dave Chinner, (Tue Nov 16, 7:11 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 7:28 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik, (Tue Nov 16, 7:34 pm)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Ted Ts'o, (Tue Nov 16, 8:06 pm)
Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik, (Tue Nov 16, 11:31 pm)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger, (Wed Nov 17, 2:19 am)
Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger, (Wed Nov 17, 2:30 am)
Re: [PATCH 3/6] Ocfs2: handle hole punching via fallocate ..., Joel Becker, (Wed Nov 17, 4:27 pm)