The mm-of-the-moment snapshot 2010-11-17-17-03 has been uploaded to http://userweb.kernel.org/~akpm/mmotm/ and will soon be available at git://zen-kernel.org/kernel/mmotm.git It contains the following patches against ...
From: Randy Dunlap <randy.dunlap@oracle.com> Fix w1_ds2423 build: needs to select CRC16. w1_ds2423.c:(.text+0x9971d): undefined reference to `crc16' w1_ds2423.c:(.text+0x9973a): undefined reference to `crc16' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Mika Laitio <lamikr@pilppa.org> --- drivers/w1/slaves/Kconfig | 1 + 1 file changed, 1 insertion(+) --- mmotm-2010-1117-1703.orig/drivers/w1/slaves/Kconfig +++ mmotm-2010-1117-1703/drivers/w1/slaves/Kconfig @@ -18,6 +18,7 @@ config W1_SLAVE_SMEM config W1_SLAVE_DS2423 tristate "Counter 1-wire device (DS2423)" + select CRC16 help If you enable this you can read the counter values available in the DS2423 chipset from the w1_slave file under the --
Thanks for noticing the missing crc16 module selection, it's indeed needed if it's not for some other reason selected in the .config. -- Terveisin Mika --
Ave 12 builds without error -- Slawa! N.P.S. Les fleurs du mal unfold Comme les fleurs du mal Dark demons of my soul Un amour fatal --
Using my current .config and a 'make oldconfig' dies a horrid quick death:
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CC arch/x86/kernel/asm-offsets.s
In file included from /usr/src/linux-2.6.37-rc2-mmotm1117/arch/x86/include/asm/suspend_64.h:10:0,
from /usr/src/linux-2.6.37-rc2-mmotm1117/arch/x86/include/asm/suspend.h:4,
from arch/x86/kernel/asm-offsets_64.c:20,
from arch/x86/kernel/asm-offsets.c:4:
/usr/src/linux-2.6.37-rc2-mmotm1117/arch/x86/include/asm/i387.h: In function 'irq_ts_save':
/usr/src/linux-2.6.37-rc2-mmotm1117/arch/x86/include/asm/i387.h:348:2: error: implicit declaration of function 'kernel_locked'
make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1
make: *** [prepare0] Error 2
static inline int irq_ts_save(void)
{
/*
* If in process context and not atomic, we can take a spurious DNA fault.
* Otherwise, doing clts() in process context requires disabling preemption
* or some heavy lifting like kernel_fpu_begin()
*/
if (!in_atomic())
return 0;
in_atomic() did me in. CONFIG_LOCK_KERNEL and CONFIG_BKL are both =y in this build.
Not sure if asm-offsets_64.c needs a #include <smp-locks.h> or if it's something else...
Hi, --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --
Turns out I don't need CONFIG_BKL anymore for anything I actually use, and setting that =n worked around it just fine.
