Re: [PATCH]oom-kill: direct hardware access processes should get bonus

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Rientjes
Date: Tuesday, November 2, 2010 - 12:34 pm

On Tue, 2 Nov 2010, Figo.zhang wrote:


Right, but you didn't explicitly prohibit such applications from being 
killed, so that suggests that doing so may be inconvenient but doesn't 
incur something like corruption or data loss, which is what I would 
consider "unstable" or "inconsistent" state.

We're trying to avoid any additional heuristics from being introduced for 
specific usecases, even for Xorg.  That ensures that the heuristic remains 
as predictable as possible and frees a large amount of memory.  If Xorg is 
being killed first instead of a true memory hogger, then it seems like a 
forkbomb scenario instead; could you please post your kernel log so that 
we can diagnose that issue seperately?


The old heuristic would allow it to elude the oom killer because it would 
divide the score by four if a task had the capability, which is a much 
more drastic "bonus" than you suggest here.  That would reduce the score 
for the memory hogging task significantly enough that we killed tons of 
innocent tasks instead before eventually killing the task that was leaking 
memory but failed to be identified because it had CAP_SYS_RAWIO.  I'm 
trying to avoid any such repeats.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH]oom-kill: direct hardware access processes shou ..., David Rientjes, (Tue Nov 2, 12:34 pm)
Re: [PATCH v2]oom-kill: CAP_SYS_RESOURCE should get bonus, David Rientjes, (Wed Nov 3, 4:47 pm)
Re:[PATCH v2]oom-kill: CAP_SYS_RESOURCE should get bonus, David Rientjes, (Wed Nov 3, 6:50 pm)
Re: [PATCH v2]oom-kill: CAP_SYS_RESOURCE should get bonus, KOSAKI Motohiro, (Tue Nov 9, 4:01 am)
Re: [PATCH v2]oom-kill: CAP_SYS_RESOURCE should get bonus, David Rientjes, (Tue Nov 9, 2:06 pm)
Re: [PATCH v2]oom-kill: CAP_SYS_RESOURCE should get bonus, David Rientjes, (Tue Nov 9, 2:25 pm)
Re: [PATCH v2]oom-kill: CAP_SYS_RESOURCE should get bonus, David Rientjes, (Wed Nov 10, 1:50 pm)
Re: [PATCH] Revert oom rewrite series, Figo.zhang, (Sun Nov 14, 8:26 pm)
Re: [PATCH] Revert oom rewrite series, David Rientjes, (Mon Nov 15, 3:14 am)
Re: [PATCH] Revert oom rewrite series, Alan Cox, (Mon Nov 15, 3:57 am)
Re: [PATCH] Revert oom rewrite series, David Rientjes, (Mon Nov 15, 1:54 pm)
Re: [PATCH] Revert oom rewrite series, KOSAKI Motohiro, (Tue Nov 23, 12:16 am)