Re: [PATCH 1/2] mfd: Provide pm_runtime_no_callbacks flag in cell data

Previous thread: [PATCH 2/2] mfd: Implement runtime PM for WM8994 core driver by Mark Brown on Friday, November 26, 2010 - 10:19 am. (1 message)

Next thread: Re: [PATCH] sh: boards: mach-se: use IS_ERR() instead of NULL check by Guennadi Liakhovetski on Friday, November 26, 2010 - 10:38 am. (4 messages)
From: Mark Brown
Date: Friday, November 26, 2010 - 10:19 am

Allow MFD cells to have pm_runtime_no_callbacks() called on them during
registration. This causes the runtime PM framework to ignore them,
allowing use of runtime PM to suspend the device as a whole even if
not all drivers for the MFD can usefully implement runtime PM. For
example, RTCs are likely to run continuously regardless of the power
state of the system.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/mfd/mfd-core.c   |    4 ++++
 include/linux/mfd/core.h |    6 ++++++
 2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index ec99f68..d83ad0f 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -15,6 +15,7 @@
 #include <linux/platform_device.h>
 #include <linux/acpi.h>
 #include <linux/mfd/core.h>
+#include <linux/pm_runtime.h>
 #include <linux/slab.h>
 
 static int mfd_add_device(struct device *parent, int id,
@@ -82,6 +83,9 @@ static int mfd_add_device(struct device *parent, int id,
 	if (ret)
 		goto fail_res;
 
+	if (cell->pm_runtime_no_callbacks)
+		pm_runtime_no_callbacks(&pdev->dev);
+
 	kfree(res);
 
 	return 0;
diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
index 5582ab3..835996e 100644
--- a/include/linux/mfd/core.h
+++ b/include/linux/mfd/core.h
@@ -47,6 +47,12 @@ struct mfd_cell {
 
 	/* don't check for resource conflicts */
 	bool			ignore_resource_conflicts;
+
+	/*
+	 * Disable runtime PM callbacks for this subdevice - see
+	 * pm_runtime_no_callbacks().
+	 */
+	bool			pm_runtime_no_callbacks;
 };
 
 extern int mfd_add_devices(struct device *parent, int id,
-- 
1.7.1

--

From: Samuel Ortiz
Date: Friday, November 26, 2010 - 5:37 pm

Hi Mark,

Makes sense, both patches applied.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--

Previous thread: [PATCH 2/2] mfd: Implement runtime PM for WM8994 core driver by Mark Brown on Friday, November 26, 2010 - 10:19 am. (1 message)

Next thread: Re: [PATCH] sh: boards: mach-se: use IS_ERR() instead of NULL check by Guennadi Liakhovetski on Friday, November 26, 2010 - 10:38 am. (4 messages)