Re: Linux 2.6.37-rc1 (libipw remove_proc_entry warning)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Friday, November 5, 2010 - 3:24 pm

This bug seems to be due to commit 27ae60f8f7aac ("ipw2x00: replace
"ieee80211" with "libipw" where appropriate"), where Pavel did this:

-       libipw_proc = proc_mkdir(DRV_NAME, init_net.proc_net);
+       libipw_proc = proc_mkdir("ieee80211", init_net.proc_net);

but then the cleanup was kept as

        remove_proc_entry(DRV_NAME, init_net.proc_net);

in both places (both in the failure case and in the unload case). The
error string is also total crap, and says

     "Unable to create " DRV_NAME " proc directory\n");

Even though it doesn't actually create a proc directory named DRV_NAME at all.

So that patch looks like total and utter crap to me. The commit message says

  "Keep /proc/net/ieee80211 under the original name to avoid breaking user
    interface."

but the thing is, it really didn't fix anything but that one create
thing. It needs to fix all the other cases too.

Totally UNTESTED patch attached. It may or may not compile. And maybe
it doesn't catch all cases, but it should catch the obvious ones.

                           Linus

On Wed, Nov 3, 2010 at 4:18 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.37-rc1, Linus Torvalds, (Mon Nov 1, 5:07 am)
Re: Linux 2.6.37-rc1, Thomas Gleixner, (Mon Nov 1, 8:37 am)
Re: Linux 2.6.37-rc1, Nick Bowler, (Mon Nov 1, 8:47 am)
Re: Linux 2.6.37-rc1, Ryusuke Konishi, (Mon Nov 1, 8:52 am)
Re: Linux 2.6.37-rc1, Linus Torvalds, (Mon Nov 1, 9:07 am)
Re: Linux 2.6.37-rc1 (acpi_video), Randy Dunlap, (Tue Nov 2, 11:51 am)
Re: Linux 2.6.37-rc1 (pcrypt fault), Randy Dunlap, (Wed Nov 3, 2:15 pm)
Re: Linux 2.6.37-rc1 (net/sched: cls_cgroup), Randy Dunlap, (Wed Nov 3, 2:21 pm)
Re: Linux 2.6.37-rc1 (net/sched: cls_cgroup), Eric Dumazet, (Wed Nov 3, 3:01 pm)
Re: Linux 2.6.37-rc1 (net/sched: cls_cgroup), Li Zefan, (Wed Nov 3, 3:19 pm)
Re: Linux 2.6.37-rc1 (net/sched: cls_cgroup), Li Zefan, (Wed Nov 3, 3:31 pm)
Re: Linux 2.6.37-rc1 (scsi_debug: list corruption), Randy Dunlap, (Wed Nov 3, 4:20 pm)
Re: Linux 2.6.37-rc1 (net/sched: cls_cgroup), Herbert Xu, (Wed Nov 3, 4:31 pm)
Re: Linux 2.6.37-rc1 (net/sched: cls_cgroup), Li Zefan, (Wed Nov 3, 6:46 pm)
Re: Linux 2.6.37-rc1 (net/sched: cls_cgroup), David Miller, (Wed Nov 3, 6:56 pm)
Re: Linux 2.6.37-rc1 (scsi_debug: list corruption), Xiaotian Feng, (Wed Nov 3, 7:25 pm)
Re: Linux 2.6.37-rc1 (net/sched: cls_cgroup), Randy Dunlap, (Thu Nov 4, 8:56 am)
Re: Linux 2.6.37-rc1 (scsi_debug: list corruption), Randy Dunlap, (Thu Nov 4, 9:12 am)
Re: Linux 2.6.37-rc1 (libipw remove_proc_entry warning), Linus Torvalds, (Fri Nov 5, 3:24 pm)
Re: Linux 2.6.37-rc1 (libipw remove_proc_entry warning), Linus Torvalds, (Fri Nov 5, 4:38 pm)
Re: Linux 2.6.37-rc1 (libipw remove_proc_entry warning), John W. Linville, (Mon Nov 8, 2:33 pm)
Re: Linux 2.6.37-rc1 (pcrypt fault), Steffen Klassert, (Wed Nov 10, 4:21 am)
Re: Linux 2.6.37-rc1 (pcrypt fault), Randy Dunlap, (Wed Nov 10, 11:11 am)