login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
December
»
12
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Russell King - ARM Linux
Subject:
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
Date: Sunday, December 12, 2010 - 7:11 am
On Sun, Dec 12, 2010 at 02:03:52PM +0000, Will Newton wrote:
quoted text
> On Sun, Dec 12, 2010 at 1:52 PM, Chris Ball <cjb@laptop.org> wrote: > > Hi Will, > > > > On Sun, Dec 12, 2010 at 10:57:44AM +0000, Will Newton wrote: > >> > drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_pull_data64’: > >> > drivers/mmc/host/dw_mmc.c:998: error: implicit declaration of function ‘__raw_readq’ > >> > > >> > because arch/arm doesn't implement raw versions of these 64-bit accesses. > >> > I'm surprised that this driver hasn't been compiled on ARM before! What > >> > >> That particular bit of code has been added since it was last built for > >> arm. Our architecture can do 64bit accesses so we implement readq. > >> Unfortunately there doesn't seem to be a sane way to conditionalize > >> code for architectures that have or don't have readq, so I suspect > >> I'll have to just remove that branch of the if statement for now. > > > > (Russell, thanks for the excellent explanation.) > > > > Other drivers (MTD, gpio/basic_mmio_gpio.c, fs/fuse, pcm_oss.c) > > conditionalize uses of {read,write}q on BITS_PER_LONG >= 64, so > > something like this: > > I don't think that's going to work, BITS_PER_LONG isn't equivalent to > "can do 64bit IO accesses", at least it isn't on our architecture. x86 > is in the same situation it would appear, although x86 does explicitly > #define readq so it may be possible to #ifdef on that?
Maybe invent CONFIG_HAVE_MMIO_64BIT which architectures can select as appropriate? --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[RESEND PATCH] dw_mmc: Add Synopsys DesignWare mmc host dr ...
, Will Newton
, (Mon Dec 6, 8:53 am)
Re: [RESEND PATCH] dw_mmc: Add Synopsys DesignWare mmc hos ...
, Matt Fleming
, (Wed Dec 8, 4:55 am)
Re: [RESEND PATCH] dw_mmc: Add Synopsys DesignWare mmc hos ...
, Will Newton
, (Wed Dec 8, 6:14 am)
[PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Will Newton
, (Wed Dec 8, 7:21 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Matt Fleming
, (Wed Dec 8, 9:07 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Chris Ball
, (Wed Dec 8, 11:47 pm)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Will Newton
, (Thu Dec 9, 5:11 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Chris Ball
, (Thu Dec 9, 9:01 am)
[PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Will Newton
, (Thu Dec 9, 10:24 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Chris Ball
, (Thu Dec 9, 10:35 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Will Newton
, (Thu Dec 9, 10:46 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Russell King - ARM Linux
, (Sun Dec 12, 1:41 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Will Newton
, (Sun Dec 12, 3:57 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Russell King - ARM Linux
, (Sun Dec 12, 4:15 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Chris Ball
, (Sun Dec 12, 6:52 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Will Newton
, (Sun Dec 12, 7:03 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Russell King - ARM Linux
, (Sun Dec 12, 7:11 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Will Newton
, (Sun Dec 12, 7:31 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Russell King - ARM Linux
, (Sun Dec 12, 7:47 am)
Re: [PATCH] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Will Newton
, (Sun Dec 12, 8:17 am)
[PATCH v4] dw_mmc: Add Synopsys DesignWare mmc host driver.
, Will Newton
, (Thu Dec 16, 10:04 am)
Re: [PATCH v4] dw_mmc: Add Synopsys DesignWare mmc host dr ...
, Chris Ball
, (Sat Jan 1, 11:20 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Og dreams of kernels
Jens Axboe
[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann
Re: finding your own dead "CONFIG_" variables
Mark Brown
[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds
[LGUEST] Look in object dir for .config
git
:
Brian Downing
Re: Git in a Nutshell guide
John Benes
Re: master has some toys
Matthias Lederhofer
[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian
[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano
Re: Rss produced by git is not valid xml?
git-commits-head
:
Linux Kernel Mailing List
iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List
ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List
ixgbe: fix several counter register errata
Linux Kernel Mailing List
b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List
9p: block-based virtio client
linux-netdev
:
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer
Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
David Daney
[PATCH 5/7] Staging: Octeon Ethernet: Convert to NAPI.
Wolfgang Grandegger
[PATCH net-next v4 1/3] can: mscan: fix improper return if dlc < 8 in start_xmi...
Amit Kumar Salecha
[PATCHv3 NEXT 2/2] NET: Add Qlogic ethernet driver for CNA devices
openbsd-misc
:
Theo de Raadt
Re: Old IPSEC bug
Tomáš Bodžár
Problem with vpnc connection - check group password !
Insan Praja SW
Mandoc Compiling Error
Carl Roberso
Re: Cannot change MTU of carp interface?
Richard Daemon
Re: booting openbsd on eee without cd-rom