Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL081 PrimeCells

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Russell King - ARM Linux
Date: Wednesday, December 22, 2010 - 5:10 pm

On Wed, Dec 22, 2010 at 03:45:39PM -0800, Dan Williams wrote:

BTW, this is misleading.  Have the functions been renamed dma_async_xxx(),
eg dma_async_memcpy_buf_to_buf etc, or are you referring just to:

	async_dmaengine_get
	async_dmaengine_put
	async_dma_find_channel
	async_dma_find_channel
	async_tx_ack
	async_tx_clear_ack
	async_tx_test_ack

Beware of just renaming it to dma_async_<operation> as there's other
functions in that namespace which may not be appropriate.

Eg, is it really illegal to issue call dma_async_issue_pending() from
IRQ context?  That'd make it exceedingly difficult to use the DMA
engine with the slave API in a lot of device drivers.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Maurus Cuelenaere, (Tue Jun 15, 4:17 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Maurus Cuelenaere, (Tue Jun 15, 5:04 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Tue Dec 21, 11:20 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Tue Dec 21, 3:25 pm)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Wed Dec 22, 5:22 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Wed Dec 22, 5:29 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Wed Dec 22, 4:54 pm)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Wed Dec 22, 5:10 pm)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Thu Dec 23, 2:18 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Thu Dec 23, 5:30 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Fri Dec 31, 2:50 pm)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Sat Jan 1, 8:15 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Sat Jan 1, 8:36 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Sun Jan 2, 4:22 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Mon Jan 3, 4:14 am)
Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL08 ..., Russell King - ARM Linux, (Mon Jan 3, 8:19 am)