Home » Mailing list archives » linux-kernel » 2010 » December » 25

Re: [PATCH] sched, cgroup: Use exit hook to avoid use-after-free crash

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Paul Menage
Subject: Re: [PATCH] sched, cgroup: Use exit hook to avoid use-after-free crash
Date: Saturday, December 25, 2010 - 1:59 pm

On Fri, Dec 24, 2010 at 3:59 PM, Peter Zijlstra <peterz@infradead.org> wrote:

While this patch is likely fine for solving the problem, it does add
extra work into the task exit path.

Could you instead just use the pre_destroy callback to return -EBUSY
if there are still any tasks on the cfs_rq? That way there'd only be a
penalty on cgroup destruction, which is a much rarer operation.

Paul
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Tue Jun 29, 3:43 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., shenghui, (Tue Jun 29, 4:24 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Tue Jun 29, 4:35 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Sat Dec 18, 7:03 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Tue Dec 21, 5:22 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 1:29 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 1:41 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Mike Galbraith, (Wed Dec 22, 1:41 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 2:07 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Wed Dec 22, 6:31 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 7:00 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 7:11 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Wed Dec 22, 8:14 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Wed Dec 22, 10:08 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Ingo Molnar, (Wed Dec 22, 10:16 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Wed Dec 22, 2:11 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Miklos Vajna, (Wed Dec 22, 4:39 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Yong Zhang, (Wed Dec 22, 7:08 pm)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Thu Dec 23, 5:12 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Thu Dec 23, 5:33 am)
Re: [PATCH] avoid race condition in pick_next_task_fair in ..., Peter Zijlstra, (Thu Dec 23, 11:24 am)
[PATCH] sched, cgroup: Use exit hook to avoid use-after-fr ..., Peter Zijlstra, (Fri Dec 24, 8:59 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Miklos Vajna, (Fri Dec 24, 9:40 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Mike Galbraith, (Fri Dec 24, 9:48 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Peter Zijlstra, (Fri Dec 24, 10:07 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Mike Galbraith, (Fri Dec 24, 10:24 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Balbir Singh, (Sat Dec 25, 10:55 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Paul Menage, (Sat Dec 25, 1:59 pm)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Ingo Molnar, (Wed Dec 29, 8:25 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Miklos Vajna, (Wed Dec 29, 4:07 pm)
[PATCH] Re: [PATCH] sched, cgroup: Use exit hook to avoid ..., Mike Galbraith, (Fri Dec 31, 1:32 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Mike Galbraith, (Fri Dec 31, 3:04 am)
Re: [PATCH] sched, cgroup: Use exit hook to avoid use-afte ..., Peter Zijlstra, (Mon Jan 3, 12:06 am)
Re: [PATCH] Re: [PATCH] sched, cgroup: Use exit hook to av ..., Peter Zijlstra, (Mon Jan 3, 1:21 am)
[tip:sched/core] sched, autogroup: Fix reference leak, tip-bot for Mike Gal ..., (Tue Jan 4, 7:19 am)
Re: [tip:sched/core] sched, autogroup: Fix reference leak, Oleg Nesterov, (Tue Jan 4, 7:57 am)
Re: [tip:sched/core] sched, autogroup: Fix reference leak, Mike Galbraith, (Tue Jan 4, 12:06 pm)