Re: Linux 2.6.37-rc8 (no fb)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jesse Barnes
Date: Wednesday, December 29, 2010 - 2:53 pm

> > Doesn't change anything here. Display stays blank.

Nevermind, I just checked out the bug, looks like it is panel power
related.  Can you try this patch?

If it doesn't work, can you send me the output of intel_reg_dumper from
before you turn off the display and after you try to turn it back on?

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index aa23070..830e3b0 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -82,8 +82,6 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds)
 		lvds_reg = LVDS;
 	}
 
-	I915_WRITE(lvds_reg, I915_READ(lvds_reg) | LVDS_PORT_EN);
-
 	if (intel_lvds->pfit_dirty) {
 		/*
 		 * Enable automatic panel scaling so that non-native modes
@@ -104,7 +102,7 @@ static void intel_lvds_enable(struct intel_lvds *intel_lvds)
 	}
 
 	I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
-	POSTING_READ(lvds_reg);
+	POSTING_READ(ctl_reg);
 
 	intel_panel_set_backlight(dev, dev_priv->backlight_level);
 }
@@ -136,8 +134,7 @@ static void intel_lvds_disable(struct intel_lvds *intel_lvds)
 		intel_lvds->pfit_dirty = true;
 	}
 
-	I915_WRITE(lvds_reg, I915_READ(lvds_reg) & ~LVDS_PORT_EN);
-	POSTING_READ(lvds_reg);
+	POSTING_READ(ctl_reg);
 }
 
 static void intel_lvds_dpms(struct drm_encoder *encoder, int mode)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.37-rc8, Linus Torvalds, (Tue Dec 28, 6:18 pm)
Re: Linux 2.6.37-rc8, Borislav Petkov, (Wed Dec 29, 4:18 am)
Re: Linux 2.6.37-rc8, Rafael J. Wysocki, (Wed Dec 29, 5:08 am)
Re: Linux 2.6.37-rc8 (no fb), Randy Dunlap, (Wed Dec 29, 11:21 am)
Re: Linux 2.6.37-rc8 (no fb), Linus Torvalds, (Wed Dec 29, 12:40 pm)
Re: Linux 2.6.37-rc8 (no fb), Jesse Barnes, (Wed Dec 29, 1:16 pm)
Re: Linux 2.6.37-rc8 (no fb), François Valenduc, (Wed Dec 29, 1:51 pm)
Re: Linux 2.6.37-rc8 (no fb), Alex Riesen, (Wed Dec 29, 2:11 pm)
Re: Linux 2.6.37-rc8 (no fb), Jesse Barnes, (Wed Dec 29, 2:18 pm)
Re: Linux 2.6.37-rc8 (no fb), Jesse Barnes, (Wed Dec 29, 2:53 pm)
Re: Linux 2.6.37-rc8 (no fb), Alex Riesen, (Wed Dec 29, 3:02 pm)
Re: Linux 2.6.37-rc8 (no fb), Randy Dunlap, (Wed Dec 29, 3:12 pm)
Re: Linux 2.6.37-rc8 (no fb), Jesse Barnes, (Wed Dec 29, 3:46 pm)
Re: Linux 2.6.37-rc8 (no fb), Alex Riesen, (Wed Dec 29, 4:09 pm)
Re: Linux 2.6.37-rc8 (no fb), Jesse Barnes, (Wed Dec 29, 4:13 pm)
Re: Linux 2.6.37-rc8 (no fb), Alex Riesen, (Wed Dec 29, 4:20 pm)
Re: Linux 2.6.37-rc8 (no fb), Alex Riesen, (Wed Dec 29, 4:35 pm)
Re: Linux 2.6.37-rc8 (no fb), Randy Dunlap, (Wed Dec 29, 4:40 pm)
Re: Linux 2.6.37-rc8 (no fb), Jesse Barnes, (Wed Dec 29, 5:02 pm)
Re: Linux 2.6.37-rc8 (no fb), Alex Riesen, (Wed Dec 29, 5:10 pm)
Re: Linux 2.6.37-rc8, Zhang Rui, (Wed Dec 29, 6:17 pm)
Re: Linux 2.6.37-rc8 (no fb), Chris Wilson, (Thu Dec 30, 11:36 am)
Re: Linux 2.6.37-rc8, Domenico Andreoli, (Mon Jan 3, 1:48 am)
Re: Linux 2.6.37-rc8, Pavel Machek, (Tue Jan 4, 7:26 am)
Re: Linux 2.6.37-rc8, Chris Wilson, (Tue Jan 4, 7:35 am)
Re: Linux 2.6.37-rc8, Pavel Machek, (Tue Jan 4, 2:04 pm)
Re: Linux 2.6.37-rc8, Dave Airlie, (Tue Jan 4, 2:15 pm)