On 12/30/2010 4:07 PM, Fabien Marteau wrote:
Please move this along with GPL text down below.
Please re-arrange these functions in such a way that you don't need
these forward declarations.
No need to mention :)
casting from void * not required.
Do you need this lock? Please explain.
As mentioned above no casting required.
No need to metnion.
No CamelCases please. Please run scripts/checkpatch.pl on your patch before submission.
What is g_num++ and why it has to be global?
Please explain why MANGLING required.
casting not required for last param.
So much for name? why not just put it like "as5011_joystick" in the call itself.
These should move to .c file.
no CamelCases please
You should better do gpio_request/free etc, in the driver itself,
and anyother thing can be left out in these hooks.
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.