Home » Mailing list archives » linux-kernel » 2010 » December » 7

Re: [PATCH 00/46] rcu-walk and dcache scaling

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Nick Piggin
Subject: Re: [PATCH 00/46] rcu-walk and dcache scaling
Date: Tuesday, December 7, 2010 - 8:24 am

On Tue, Dec 7, 2010 at 10:25 PM, Dave Chinner <david@fromorbit.com> wrote:

Thanks for testing...



Seems that lockdep exploded.


So I vfs-scale-working branch may not be entirely in the clear, seeing
as it touches
the code lower in the call chain. However I don't know what can cause
lockdep to go off
the rails like this.

There is a sequence I used to hack around lockdep nesting
restrictions, following this
pattern:

 repeat:
    spin_lock(&parent->d_lock);
    spin_lock_nested(&dentry->d_lock, DENTRY_D_LOCK_NESTED);
    /* do stuff */
    spin_unlock(&parent->d_lock);
    spin_release(&dentry->d_lock.dep_map, 1, _RET_IP_);
    parent = dentry;
    spin_acquire(&this_parent->d_lock.dep_map, 0, 1, _RET_IP_);
    goto repeat;

It's not directly in this call chain, but I wonder if it could have
caused any problem?
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 02/46] fs: d_validate fixes, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 06/46] cifs: dont overwrite dentry name in d_revalidate, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 07/46] jfs: dont overwrite dentry name in d_revalidate, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 08/46] fs: change d_compare for rcu-walk, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 09/46] fs: change d_hash for rcu-walk, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 10/46] hostfs: simplify locking, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 11/46] fs: dcache scale hash, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 15/46] fs: dcache scale subdirs, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 16/46] fs: scale inode alias list, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 17/46] fs: Use rename lock and RCU for multi-step o ..., Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 23/46] fs: dcache reduce dcache_inode_lock, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 26/46] fs: dcache reduce prune_one_dentry locking, Nick Piggin, (Sat Nov 27, 2:44 am)
[PATCH 30/46] fs: icache RCU free inodes, Nick Piggin, (Sat Nov 27, 2:45 am)
[PATCH 35/46] fs: dcache remove d_mounted, Nick Piggin, (Sat Nov 27, 2:45 am)
[PATCH 36/46] fs: dcache reduce branches in lookup path, Nick Piggin, (Sat Nov 27, 2:45 am)
[PATCH 40/46] fs: provide rcu-walk aware permission i_ops, Nick Piggin, (Sat Nov 27, 2:45 am)
[PATCH 44/46] fs: dcache per-bucket dcache hash locking, Nick Piggin, (Sat Nov 27, 2:45 am)
[PATCH 45/46] fs: dcache per-inode inode alias locking, Nick Piggin, (Sat Nov 27, 2:45 am)
[PATCH 01/46] Revert &quot;fs: use RCU read side protection in ..., Nick Piggin, (Sat Nov 27, 2:56 am)
[PATCH 00/46] rcu-walk and dcache scaling, Nick Piggin, (Sat Nov 27, 3:15 am)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Anca Emanuel, (Sat Nov 27, 8:04 am)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Nick Piggin, (Sat Nov 27, 8:28 pm)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Sedat Dilek, (Sat Nov 27, 11:24 pm)
Re: [PATCH 00/46] rcu-walk and dcache scaling, David Miller, (Wed Dec 1, 11:03 am)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Nick Piggin, (Fri Dec 3, 9:55 am)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Nick Piggin, (Tue Dec 7, 8:24 am)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Peter Zijlstra, (Tue Dec 7, 8:49 am)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Nick Piggin, (Tue Dec 7, 8:59 am)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Peter Zijlstra, (Tue Dec 7, 9:23 am)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Dave Chinner, (Tue Dec 7, 2:56 pm)
Re: [PATCH 01/46] Revert &quot;fs: use RCU read side protection ..., Dave Chinner, (Tue Dec 7, 6:16 pm)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Nick Piggin, (Tue Dec 7, 6:47 pm)
Re: [PATCH 02/46] fs: d_validate fixes, Dave Chinner, (Tue Dec 7, 6:53 pm)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Nick Piggin, (Tue Dec 7, 8:28 pm)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Dave Chinner, (Tue Dec 7, 8:32 pm)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Dave Chinner, (Tue Dec 7, 9:28 pm)
Re: [PATCH 02/46] fs: d_validate fixes, Nick Piggin, (Tue Dec 7, 11:59 pm)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Nick Piggin, (Wed Dec 8, 12:09 am)
Re: [PATCH 01/46] Revert &quot;fs: use RCU read side protection ..., Nick Piggin, (Wed Dec 8, 2:38 am)
Re: [PATCH 01/46] Revert &quot;fs: use RCU read side protection ..., Dave Chinner, (Wed Dec 8, 5:44 pm)
Re: [PATCH 02/46] fs: d_validate fixes, Dave Chinner, (Wed Dec 8, 5:50 pm)
Re: [PATCH 01/46] Revert &quot;fs: use RCU read side protection ..., Nick Piggin, (Wed Dec 8, 9:38 pm)
Re: [PATCH 02/46] fs: d_validate fixes, Nick Piggin, (Wed Dec 8, 9:50 pm)
Re: [PATCH 01/46] Revert &quot;fs: use RCU read side protection ..., Nick Piggin, (Wed Dec 8, 10:16 pm)
Re: [PATCH 11/46] fs: dcache scale hash, Dave Chinner, (Wed Dec 8, 11:09 pm)
Re: [PATCH 11/46] fs: dcache scale hash, Nick Piggin, (Wed Dec 8, 11:28 pm)
Re: [PATCH 11/46] fs: dcache scale hash, Dave Chinner, (Thu Dec 9, 1:17 am)
Re: [PATCH 11/46] fs: dcache scale hash, Nick Piggin, (Thu Dec 9, 5:53 am)
Re: [PATCH 11/46] fs: dcache scale hash, Dave Chinner, (Thu Dec 9, 4:42 pm)
Re: [PATCH 11/46] fs: dcache scale hash, Nick Piggin, (Thu Dec 9, 7:35 pm)
Re: [PATCH 11/46] fs: dcache scale hash, Dave Chinner, (Fri Dec 10, 2:01 am)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Paul E. McKenney, (Fri Dec 10, 1:32 pm)
Re: [PATCH 00/46] rcu-walk and dcache scaling, Paul E. McKenney, (Sun Dec 12, 7:54 am)
Re: [PATCH 11/46] fs: dcache scale hash, Nick Piggin, (Sun Dec 12, 9:48 pm)
Re: [PATCH 11/46] fs: dcache scale hash, Nick Piggin, (Sun Dec 12, 10:05 pm)