Re: [PATCH 2/3] input: use input_mutex instead of BKL when opening input device

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Oliver Neukum

Subject: Re: [PATCH 2/3] input: use input_mutex instead of BKL when opening input device

Date: Tuesday, March 9, 2010 - 11:49 pm

Am Mittwoch, 10. März 2010 07:20:15 schrieb Dmitry Torokhov:
quoted text> > I was willing to let the open call go unprotected. But ended up checking
> > that the three callees were fine (they do not call any of the other
> > functions that take the mutex).
> > 
> > Since the fops_put/fops_get do protect that section from the handler
> > removal and I can't think of any other race right now, I think your
> > version is really better.
> > 
> > Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> > 
> 
> OK, applied 2 Thadeu's patches and one Arnd's.

Jiri,

it is possible that this requires a change in usbhid as it uses BKL.
Do you remember?

	Regards
		Oliver
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/3] input: remove BKL from mousedev, Thadeu Lima de Souza ..., (Tue Mar 9, 12:19 pm)

[PATCH 2/3] input: use input_mutex instead of BKL when ope ..., Thadeu Lima de Souza ..., (Tue Mar 9, 12:19 pm)

[PATCH 3/3] input: remove BKL from serio_raw, Thadeu Lima de Souza ..., (Tue Mar 9, 12:19 pm)

Re: [PATCH 1/3] input: remove BKL from mousedev, Arnd Bergmann, (Tue Mar 9, 1:05 pm)

Re: [PATCH 2/3] input: use input_mutex instead of BKL when ..., Arnd Bergmann, (Tue Mar 9, 1:06 pm)

Re: [PATCH 3/3] input: remove BKL from serio_raw, Arnd Bergmann, (Tue Mar 9, 1:06 pm)

Re: [PATCH 2/3] input: use input_mutex instead of BKL when ..., Arnd Bergmann, (Tue Mar 9, 1:12 pm)

Re: [PATCH 2/3] input: use input_mutex instead of BKL when ..., Thadeu Lima de Souza ..., (Tue Mar 9, 1:59 pm)

Re: [PATCH 2/3] input: use input_mutex instead of BKL when ..., Dmitry Torokhov, (Tue Mar 9, 11:20 pm)

Re: [PATCH 2/3] input: use input_mutex instead of BKL when ..., Oliver Neukum, (Tue Mar 9, 11:49 pm)

Re: [PATCH 2/3] input: use input_mutex instead of BKL when ..., Dmitry Torokhov, (Tue Mar 9, 11:56 pm)